From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58309 invoked by alias); 18 Mar 2019 03:55:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58296 invoked by uid 89); 18 Mar 2019 03:55:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=mind X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 18 Mar 2019 03:55:24 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B593D3084267; Mon, 18 Mar 2019 03:55:23 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 88DE35D9D3; Mon, 18 Mar 2019 03:55:23 +0000 (UTC) From: Sergio Durigan Junior To: Sergei Trofimovich Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: unconditionally define _initialize_string_view_selftests References: <20190314222828.28798-1-slyfox@gentoo.org> <87ftrob4ha.fsf@tromey.com> <20190317222004.0afa508d@sf> Date: Mon, 18 Mar 2019 03:55:00 -0000 In-Reply-To: <20190317222004.0afa508d@sf> (Sergei Trofimovich's message of "Sun, 17 Mar 2019 22:20:04 +0000") Message-ID: <87va0gq1jo.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00364.txt.bz2 On Sunday, March 17 2019, Sergei Trofimovich wrote: > On Fri, 15 Mar 2019 08:24:17 -0600 > Tom Tromey wrote: > >> >>>>> "Sergei" == Sergei Trofimovich writes: >> >> Sergei> The build failure was noticed by Helmut Jarausch in >> Sergei> https://bugs.gentoo.org/680232: >> Sergei> $ ./configure CXXFLAGS='-std=c++17 -Os' >> Sergei> ... >> Sergei> CXXLD gdb >> Sergei> ld: init.o: in function `initialize_all_files()': >> Sergei> init.c:(.text+0x113): undefined reference to `_initialize_string_view_selftests()' >> >> Sergei> It happens because '_initialize_string_view_selftests()' is >> Sergei> conditionally defined based on C++ default. >> >> Sergei> The change defines '_initialize_string_view_selftests()' >> Sergei> unconditionally and leaves implementation a no-op on c++17 >> Sergei> compilers. >> >> Thank you. This is OK with a ChangeLog entry. >> Let me know if you need me to check it in for you. > > Thank you for the quick review! Yes, I need someone to check the > change in for me. Should I indicate it the patch email next time? Either that, or you can request commit access to the repository here: https://sourceware.org/cgi-bin/pdw/ps_form.cgi I'm not a global maintainer, but I believe Tom wouldn't mind if you put him as the person who approved the request. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/