From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92623 invoked by alias); 27 Mar 2019 20:21:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92590 invoked by uid 89); 27 Mar 2019 20:21:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Mar 2019 20:21:16 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id E82CD2A599 for ; Wed, 27 Mar 2019 15:21:14 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9F2whiQOZYTGM9F2whtjED; Wed, 27 Mar 2019 15:21:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xxO/8B6FGWIVDXtfhMHYicjNuQE29HQE9MDqC5l+FYI=; b=m2Lzk3RP3aok5d9Gh7a1qmiJk0 tY2sQxpWLm8x4E1DLvA6+kb5Q2xKtnHrevsqSFFJrlEoksasO/CHf11Ea590lyga26jjQ7w0FFNv+ xI6v/0fNjUEcRzPTS9IMIIIny; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:42280 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h9F2w-000Fql-M8; Wed, 27 Mar 2019 15:21:14 -0500 From: Tom Tromey To: Kevin Buettner Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3 2/6] Add python method InferiorThread.handle References: <20190320213250.718c4c19@f29-4.lan> <20190320214459.526c859a@f29-4.lan> Date: Wed, 27 Mar 2019 20:21:00 -0000 In-Reply-To: <20190320214459.526c859a@f29-4.lan> (Kevin Buettner's message of "Wed, 20 Mar 2019 21:44:59 -0700") Message-ID: <87va04kr0m.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00647.txt.bz2 >>>>> "Kevin" == Kevin Buettner writes: Kevin> +static PyObject * Kevin> +thpy_thread_handle (PyObject *self, PyObject *args) [...] Kevin> + if (hv.size () == 0) Kevin> + return NULL; A function like this must ensure that the Python exception is set before returning NULL. I think more is needed here, because I don't think this does that. Tom