From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110872 invoked by alias); 19 Dec 2019 18:16:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110824 invoked by uid 89); 19 Dec 2019 18:16:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 18:16:40 +0000 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id F1A9C400C2EEE for ; Thu, 19 Dec 2019 12:16:38 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id i0LmiFt7zW4fri0LmiZapf; Thu, 19 Dec 2019 12:16:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jZ3+YCuQJnWykLVSK5Zjx5tvhedsklxJiA1b6A4B6zE=; b=wP8hzKXiu3Ze1FUZJydcAvVw4R E9CBEM/uhY0QY9AN0SxVrgc1FRzkSFfbkK5HUMK3Vo5CCRVTz9jJBxOGX3FQmGqUyLqw1tfZGVCs0 BBGMPAccAT0dwSu91H7HYJh0o; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:37460 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ii0Lm-00166d-MX; Thu, 19 Dec 2019 11:16:38 -0700 From: Tom Tromey To: "Christian Biesinger via gdb-patches" Cc: Christian Biesinger Subject: Re: [PATCH] Rename "sun" variable to avoid conflicts on Solaris References: <20191218225216.7073-1-cbiesinger@google.com> Date: Thu, 19 Dec 2019 18:16:00 -0000 In-Reply-To: <20191218225216.7073-1-cbiesinger@google.com> (Christian Biesinger via gdb-patches's message of "Wed, 18 Dec 2019 16:52:16 -0600") Message-ID: <87v9qcb2pl.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00825.txt.bz2 >>>>> "Christian" == Christian Biesinger via gdb-patches writes: Christian> A Solaris system header has a #define for "sun". This renames Christian> that variable to avoid the conflict, fixing a build error with Christian> --enable-targets=all on Solaris. Christian> gdb/ChangeLog: Christian> 2019-12-18 Christian Biesinger Christian> * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var Christian> "sun" to "saddr_un". Thanks, this is ok. Tom