Re: [PATCH] gdb: use std::vector instead of alloca in core_target::get_core_register_section

Tom Tromey
2020-01-13T17:30:56Z

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> We are using alloca to hold the contents of a the core register
Simon> sections. These sections are typically fairly small, but there is no
Simon> realy guarantee, so I think it would be more reasonable to just use
Simon> dynamic allocation here.

I would be fine with simply avoiding alloca in most, or all, cases.

Simon> gdb/ChangeLog:

Simon> * corelow.c (core_target::get_core_register_section): Use
Simon> std::vector instead of alloca.

Looks reasonable to me.

Tom