Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>,
	 Christian Biesinger <cbiesinger@google.com>
Subject: Re: [pushed] Remove useless NULL check in python.c
Date: Wed, 19 Feb 2020 15:35:00 -0000	[thread overview]
Message-ID: <87v9o2zj30.fsf@tromey.com> (raw)
In-Reply-To: <CAPTJ0XHinQErb9_gbKM-sTqhvkQ_-6WNTdavtbfKqCD4SX1zMw@mail.gmail.com>	(Christian Biesinger via gdb-patches's message of "Wed, 19 Feb 2020	19:16:26 +0400")

>>>>> "Christian" == Christian Biesinger via gdb-patches <gdb-patches@sourceware.org> writes:

Christian> Have you considered using STD::wstring instead of this manual memory
Christian> management?

I did, but converting to wstring seemed unusually complicated compared
to what we have.  Though, this isn't a part of C++ that I know well, so
I'm open to being wrong about that.

Tom


      reply	other threads:[~2020-02-19 15:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19 14:57 Tom Tromey
2020-02-19 15:16 ` Christian Biesinger via gdb-patches
2020-02-19 15:35   ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9o2zj30.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=cbiesinger@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox