From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 13CLK7HPkl+ZXQAAWB0awg (envelope-from ) for ; Fri, 23 Oct 2020 08:42:25 -0400 Received: by simark.ca (Postfix, from userid 112) id A5B691EE09; Fri, 23 Oct 2020 08:42:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 40C3B1E58D for ; Fri, 23 Oct 2020 08:42:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5F103858039; Fri, 23 Oct 2020 12:42:24 +0000 (GMT) Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.51]) by sourceware.org (Postfix) with ESMTPS id 90D813858039 for ; Fri, 23 Oct 2020 12:42:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 90D813858039 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id CCA685D57D for ; Fri, 23 Oct 2020 07:42:20 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id VwOikZkQrCjCVVwOikqAOI; Fri, 23 Oct 2020 07:42:20 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8boQZ66t8CvJtHK7GUm+IRhbEKblI38Pq3mgzC5V0jg=; b=EayCDXfqS3EbmLT9ze/nnKVh/u POVpTYLabJR5CLeo5Pxtu98MrpJGza2Ac8PgtxWst3+VSkO5dUMe7KAAaxHjfXrYzJ6d/BW6IJ8wM ioH6UOlTI53MyyKXEoZmQGppP; Received: from 75-166-102-113.hlrn.qwest.net ([75.166.102.113]:33928 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kVwOi-0049ds-Gk; Fri, 23 Oct 2020 06:42:20 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [committed][gdb/symtab] Make find_block_in_blockvector more robust References: <20201022152431.GA13910@delia> <87ft66144u.fsf@tromey.com> <8d84b50e-530a-a33c-b523-c72305438c19@suse.de> X-Attribution: Tom Date: Fri, 23 Oct 2020 06:42:19 -0600 In-Reply-To: <8d84b50e-530a-a33c-b523-c72305438c19@suse.de> (Tom de Vries's message of "Thu, 22 Oct 2020 23:21:21 +0200") Message-ID: <87v9f1yuz8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.102.113 X-Source-L: No X-Exim-ID: 1kVwOi-0049ds-Gk X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-102-113.hlrn.qwest.net (murgatroyd) [75.166.102.113]:33928 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >> This seems a bit weird to me, in that if BLOCK_START(b) == pc, then I >> would be inclined to say that the pc is in fact in that block. Tom> So if BLOCK_START(b) == pc, indeed the pc is in the block, and we have: Tom> ... Tom> if (!(true)) Tom> return NULL; Tom> ... Tom> which I'd say correctly handles that case. I guess I missed the "!". Thank you. Tom