From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ScwZEvtYnF+9LwAAWB0awg (envelope-from ) for ; Fri, 30 Oct 2020 14:18:35 -0400 Received: by simark.ca (Postfix, from userid 112) id 42CD31EFC1; Fri, 30 Oct 2020 14:18:35 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.4 required=5.0 tests=DKIM_SIGNED,MAILING_LIST_MULTI, RCVD_IN_BL_SPAMCOP_NET,T_DKIM_INVALID,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 75EAF1E58E for ; Fri, 30 Oct 2020 14:18:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 327163851C25; Fri, 30 Oct 2020 18:18:34 +0000 (GMT) Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.146.119]) by sourceware.org (Postfix) with ESMTPS id 63ACE3851C25 for ; Fri, 30 Oct 2020 18:18:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 63ACE3851C25 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id D2A1674AC for ; Fri, 30 Oct 2020 13:18:30 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YYyskDVdiosA0YYyskwHMY; Fri, 30 Oct 2020 13:18:30 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w4Qx/IcFKYq6kNyHs+9vfnA4R4GmF1tLuC2CtKPGoMY=; b=Dh9UMF1gNPG+ANZU5cyPG6IIo0 D3gjRRazRy+YBqcH1QXtSgVxmfwlrgaI0TJq1Vmrk1RwqxOJzVvz+r+JjpC8LVSfzqTK3gKBfpkD/ MO7OQfbI6773pr6F6xac9Jx7I; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:59282 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kYYys-000JhC-Jj; Fri, 30 Oct 2020 12:18:30 -0600 From: Tom Tromey To: Tom de Vries Subject: Re: [committed][gdb/testsuite] Fix gdb.rust/traits.exp with -readnow References: <20201028200757.GA27867@delia> X-Attribution: Tom Date: Fri, 30 Oct 2020 12:18:28 -0600 In-Reply-To: <20201028200757.GA27867@delia> (Tom de Vries's message of "Wed, 28 Oct 2020 21:07:58 +0100") Message-ID: <87v9ertw5n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kYYys-000JhC-Jj X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:59282 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" >>>>> "Tom" == Tom de Vries writes: Tom> +proc readnow { args } { Tom> + if { [llength $args] == 1 } { Tom> + set re [lindex $args 0] Tom> + } else { Tom> + set re "" Tom> + } It's better to use Tcl's argument-passing conventions rather than implement it in the proc. I know dejagnu (and thus the gdb test suite) does this, but that's not a great example to copy. Something like this would achieve the same effect: proc readnow {{re ""}} { ... Tom