From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wA2uAZLCwl9kcwAAWB0awg (envelope-from ) for ; Sat, 28 Nov 2020 16:35:14 -0500 Received: by simark.ca (Postfix, from userid 112) id 025A31F0AB; Sat, 28 Nov 2020 16:35:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A99B01E552 for ; Sat, 28 Nov 2020 16:35:13 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F3D653854803; Sat, 28 Nov 2020 21:35:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F3D653854803 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606599313; bh=qGLMH8khaEq0BTgQbhwE9cGyRj/WSC1cq9AJsTIJ5+I=; h=To:Subject:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mlpp6OwQ1OX+uq9CexIXcXkMI54aApBG/DT+NhthE95iHkCiWr85yweK5DwLIP8Il 3BSnsLdAC9CZZxxCajqVkxhCTyxH/GqV1ky7qQgn2KxImypHvB5gP+Dh8HbGukNSR4 XYZvaCe5vZEazJWFMZyI9i5yiOcLZWMCddJyykRA= Received: from mail.sergiodj.net (mail.sergiodj.net [167.114.15.217]) by sourceware.org (Postfix) with ESMTPS id E3E013854803 for ; Sat, 28 Nov 2020 21:35:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E3E013854803 Received: from localhost (bras-base-toroon1016w-grc-37-76-65-22-220.dsl.bell.ca [76.65.22.220]) by mail.sergiodj.net (Postfix) with ESMTPSA id 845AAA00BB; Sat, 28 Nov 2020 16:35:10 -0500 (EST) To: Sergio Durigan Junior via Gdb-patches Subject: Re: [PATCH v2] Search for DWZ files in debug-file-directories as well References: <20201114234842.2334396-1-sergiodj@sergiodj.net> <20201119022708.3627287-1-sergiodj@sergiodj.net> <87zh31yza7.fsf@paluero> X-URL: http://blog.sergiodj.net Date: Sat, 28 Nov 2020 16:35:10 -0500 In-Reply-To: <87zh31yza7.fsf@paluero> (Sergio Durigan Junior via Gdb-patches's message of "Sat, 28 Nov 2020 15:58:08 -0500") Message-ID: <87v9dpyxkh.fsf@paluero> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergio Durigan Junior via Gdb-patches Reply-To: Sergio Durigan Junior Cc: Simon Marchi , Mark Wielaard Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On Saturday, November 28 2020, Sergio Durigan Junior via Gdb-patches wrote: > On Thursday, November 26 2020, Simon Marchi wrote: > >> On 2020-11-18 9:27 p.m., Sergio Durigan Junior via Gdb-patches wrote: >>> + >>> + dwz_bfd = gdb_bfd_open (new_filename.c_str (), gnutarget); >>> + >>> + if (dwz_bfd != nullptr) >>> + { >>> + if (!build_id_verify (dwz_bfd.get (), buildid_len, buildid)) >>> + { >>> + dwz_bfd.reset (nullptr); >> >> Just ".reset ()". > > OK. FWIW, ".reset ()" doesn't work. It has to be ".reset (nullptr)". -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible https://sergiodj.net/