Re: [PATCH][gdb/breakpoints] Fix longjmp master breakpoint with separate debug info

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> 2021-01-27  Tom de Vries  <tdevries@suse.de>

Tom> 	PR breakpoints/27205
Tom> 	* breakpoint.c (create_longjmp_master_breakpoint_probe)
Tom> 	(create_longjmp_master_breakpoint_names): New function, factored out
Tom> 	of ...
Tom> 	(create_longjmp_master_breakpoint): ... here.  Only try to install
Tom> 	longjmp_names breakpoints in libc.so/libc.so.debug if installing probe
Tom> 	breakpoint in libc.so failed.

This looks reasonable to me.  Thanks for doing it.

Tom> +	  /* Skip separate debug object.  */
Tom> +	  if (obj->separate_debug_objfile_backlink)

Normally this would be written != nullptr.

Tom> +	  /* Iterate over separate debug objects and try longjmp_names
Tom> +	     kind breakpoints.  */
Tom> +	  for (objfile *sepdebug = obj->separate_debug_objfile;
Tom> +	       sepdebug != nullptr; sepdebug = sepdebug->separate_debug_objfile)
Tom> +	    if (create_longjmp_master_breakpoint_names (sepdebug))
Tom> +	      break;

I guess this can't use separate_debug_iterator / separate_debug_range
since that returns the parent objfile first.

Tom