From: Tom Tromey <tom@tromey.com>
To: tdevries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/build] Hardcode --with-included-regex
Date: Wed, 21 Apr 2021 10:59:15 -0600 [thread overview]
Message-ID: <87v98fbml8.fsf@tromey.com> (raw)
In-Reply-To: <77a676bcd18e5603a4597fee89dc4269@suse.de> (tdevries@suse.de's message of "Mon, 19 Apr 2021 22:33:07 +0200")
>> In gdb_regex.{c,h}, we have compiled_regex::search, which uses GNU
>> regex function re_search. The functionality is actually used,
>> removing it breaks the gdb build.
>> So I don't quite understand your remark.
No, it's me who didn't understand -- I missed this important detail.
I think your idea is correct: we should use the libiberty regex, and if
we really need to use the glibc one, we should import it via gnulib.
(Or maybe put this same logic into libiberty.)
I think your patch is ok. Thank you.
Tom
prev parent reply other threads:[~2021-04-21 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 15:34 Tom de Vries
2021-04-19 19:47 ` Tom Tromey
2021-04-19 20:33 ` tdevries
2021-04-21 16:59 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v98fbml8.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox