Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org>
Cc: jinisusan.george@amd.com,
	Bernhard Heckel <bernhard.heckel@intel.com>,
	Tim Wiederhake <tim.wiederhake@intel.com>
Subject: Re: [PATCH v2 1/1] dwarf, fortran: add support for DW_TAG_entry_point
Date: Fri, 15 Apr 2022 09:27:43 -0600	[thread overview]
Message-ID: <87v8va1i4w.fsf@tromey.com> (raw)
In-Reply-To: <20220414094108.2758482-2-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Thu, 14 Apr 2022 11:41:08 +0200")

>>>>> Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org> writes:

> diff --git a/gdb/dwarf2/abbrev.c b/gdb/dwarf2/abbrev.c
> index 2db5ea15ac..3b47987a0e 100644
> --- a/gdb/dwarf2/abbrev.c
> +++ b/gdb/dwarf2/abbrev.c
> @@ -88,6 +88,7 @@ tag_interesting_for_index (dwarf_tag tag)
>      case DW_TAG_base_type:
>      case DW_TAG_class_type:
>      case DW_TAG_constant:
> +    case DW_TAG_entry_point:
>      case DW_TAG_enumeration_type:
>      case DW_TAG_enumerator:
>      case DW_TAG_imported_declaration:

I wonder what happens if this is removed.

If it's needed I suppose I would expect some other changes to the
indexer.  Like maybe cooked_indexer::index_dies has to handle it, or
cooked_index_entry::matches(search_domain).

Tom

  parent reply	other threads:[~2022-04-15 15:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14  9:41 [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point Nils-Christian Kempke via Gdb-patches
2022-04-14  9:41 ` [PATCH v2 1/1] dwarf, fortran: add support for DW_TAG_entry_point Nils-Christian Kempke via Gdb-patches
2022-04-14 22:05   ` Kevin Buettner via Gdb-patches
2022-04-15 15:27   ` Tom Tromey [this message]
2022-05-12 10:38     ` Kempke, Nils-Christian via Gdb-patches
2022-05-26 17:34       ` Tom Tromey
2022-07-06 15:30         ` Kempke, Nils-Christian via Gdb-patches
2022-04-19 11:53 ` [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point George, Jini Susan via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8va1i4w.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=bernhard.heckel@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jinisusan.george@amd.com \
    --cc=tim.wiederhake@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox