From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8L1CAMS3amI2JgMAWB0awg (envelope-from ) for ; Thu, 28 Apr 2022 11:50:28 -0400 Received: by simark.ca (Postfix, from userid 112) id EEE5F1E058; Thu, 28 Apr 2022 11:50:27 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=SKaBiBqh; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 868D21E01D for ; Thu, 28 Apr 2022 11:50:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12FA93886C4A for ; Thu, 28 Apr 2022 15:50:27 +0000 (GMT) Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id 9EB253839428 for ; Thu, 28 Apr 2022 15:50:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9EB253839428 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 1144B10048737 for ; Thu, 28 Apr 2022 15:50:16 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id k6PHndWZiY8yck6PHnD7YW; Thu, 28 Apr 2022 15:50:16 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=TZJTCTch c=1 sm=1 tr=0 ts=626ab7b8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=7s-Dh8U5QiBbz4Z5fWgA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qosUEoK6oGD2C5vHEKHb8r1YfIeer1w8BJj6NgJ46bU=; b=SKaBiBqhako1GWHQR36j88TgLP 4bj51EbCMYjPK4cPHeRPM4pBfYwfB5cjCc4zf0P+wBIL/d6xtwgeQN7hIQosWbXyDbejd8unmd+Lj +nEZgKRl+bWYMhiQzQfJhB1Kq; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:55698 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nk6PH-001ups-Bu; Thu, 28 Apr 2022 09:50:15 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH v3 2/7] gdb: add debug prints in buildsym.c References: <20220428033542.1636284-1-simon.marchi@polymtl.ca> <20220428033542.1636284-3-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 28 Apr 2022 09:50:14 -0600 In-Reply-To: <20220428033542.1636284-3-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Wed, 27 Apr 2022 23:35:37 -0400") Message-ID: <87v8utky15.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1nk6PH-001ups-Bu X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (murgatroyd) [71.211.158.194]:55698 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Add a few debug prints in buildsym.c that were helpful to me in writing Simon> this series. This seems fine to me. I think I'd only ever hesitate at adding logging if it's either in a hot path or if the message was somehow not useful. Tom