From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 9yd1OhFdsmQZcyIAWB0awg (envelope-from ) for ; Sat, 15 Jul 2023 04:47:13 -0400 Received: by simark.ca (Postfix, from userid 112) id DEE801E0AC; Sat, 15 Jul 2023 04:47:13 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C51F11E0AC for ; Sat, 15 Jul 2023 04:47:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13C1F3858C52 for ; Sat, 15 Jul 2023 08:47:11 +0000 (GMT) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) by sourceware.org (Postfix) with ESMTPS id 6BFA73858D3C for ; Sat, 15 Jul 2023 08:46:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BFA73858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nefkom.net Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4R325X6jMCz1r68n; Sat, 15 Jul 2023 10:46:56 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4R325X3FsWz1qqlW; Sat, 15 Jul 2023 10:46:56 +0200 (CEST) X-Virus-Scanned: amavis at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id 8T2R7Yf42DJR; Sat, 15 Jul 2023 10:46:55 +0200 (CEST) X-Auth-Info: O13zH6ePlUVErJwunImgv83ZBxFyQ9B6uIw6JSwQu16aE/nj9uJVycFYJH+a9NFU Received: from tiger.home (aftr-62-216-205-205.dynamic.mnet-online.de [62.216.205.205]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 15 Jul 2023 10:46:55 +0200 (CEST) Received: by tiger.home (Postfix, from userid 1000) id 5F3231C94D8; Sat, 15 Jul 2023 10:46:55 +0200 (CEST) From: Andreas Schwab To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [pushed] [gdb/testsuite] Fix gdb.dwarf2/forward-spec.exp with read1 In-Reply-To: <20230715081104.2452-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Sat, 15 Jul 2023 10:11:04 +0200") References: <20230715081104.2452-1-tdevries@suse.de> X-Yow: .. I don't understand the HUMOR of the THREE STOOGES!! Date: Sat, 15 Jul 2023 10:46:55 +0200 Message-ID: <87v8elef40.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_HTTP, RCVD_IN_SORBS_SOCKS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Jul 15 2023, Tom de Vries via Gdb-patches wrote: > diff --git a/gdb/testsuite/gdb.dwarf2/forward-spec.exp b/gdb/testsuite/gdb.dwarf2/forward-spec.exp > index ac7d16b09b8..f4512cf9b8c 100644 > --- a/gdb/testsuite/gdb.dwarf2/forward-spec.exp > +++ b/gdb/testsuite/gdb.dwarf2/forward-spec.exp > @@ -74,7 +74,7 @@ if {[prepare_for_testing "failed to prepare" ${testfile} \ > > set in_v 0 > gdb_test_multiple "maint print objfiles" "v has a parent" { > - -re "^ *\\\[\[0-9\]\\\] *..cooked_index_entry\[^\r\n\]*" { > + -re "^ *\\\[\[0-9\]\\\] *\\(\\(cooked_index_entry\[^\r\n\]*" { A match that ends with an empty element doesn't make much sense. I guess this should rather be -re "^ *\\\[\[0-9\]\\\] *..cooked_index_entry\[^\r\n\]*\[\r\n\]" { to avoid matching an incomplete line. > set in_v 0 > exp_continue > } > @@ -82,7 +82,7 @@ gdb_test_multiple "maint print objfiles" "v has a parent" { > set in_v 1 > exp_continue > } > - -re "^ *parent: *..cooked_index_entry .. (0|$hex)." { > + -re "^ *parent: *\\(\\(cooked_index_entry \\*\\) (0|$hex)\\)" { I think this just needs to be anchored on EOL as well. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."