From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 15fwDGB/xmWRkRgAWB0awg (envelope-from ) for ; Fri, 09 Feb 2024 14:39:12 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=TD/HKHJj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1FAE61E0C3; Fri, 9 Feb 2024 14:39:12 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 01ABB1E092 for ; Fri, 9 Feb 2024 14:39:09 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C4A13858417 for ; Fri, 9 Feb 2024 19:39:09 +0000 (GMT) Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id CBA103858D3C for ; Fri, 9 Feb 2024 19:38:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CBA103858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CBA103858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707507530; cv=none; b=s6tD8PPlP/5mCSI7bPg/jDlrrF+VyL7SbFzT/UYxsIWmhVrduHfg+pAtglADGDSjKW7YaAhkd/x1QnhiIuGyNSN0oapxy+qD093sdSYJiqvSMvRnzMLoegMYKPQvv41xW1XUJSqrerYkoXlq4Oz9NOQV3rRYYTEt2lwsR/TZfYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707507530; c=relaxed/simple; bh=lBobUDpcJoXCCtwMOrYsV/6QyJ0O7JPmRT72nLuKRFE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oaE4X4CZbe7BA/glYVUfKTeLbctX7J573G1yUIOnQkUqv9UnTmsn101dLmMTcyxTSKC/vt+z7y5O1cMpbQ8fdR6xR9OlolEL3U2w4MvosFv3+m57LR1d5QyK9eAwWJDIjMgKlU4WtfAtQ8G2Gbbim/C6sun7NXi+9bDaSJpJgFg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5010a.ext.cloudfilter.net ([10.0.29.199]) by cmsmtp with ESMTPS id YV9erF2W68uLRYWi0rL9Sb; Fri, 09 Feb 2024 19:38:48 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id YWhzrHgNph0SYYWhzrpz1H; Fri, 09 Feb 2024 19:38:48 +0000 X-Authority-Analysis: v=2.4 cv=M+/uKDws c=1 sm=1 tr=0 ts=65c67f48 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=RtkggBvCAAAA:8 a=nZd5dxZGAGNPxTAswoYA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qoNWTc3oLHUL5zYByeXsgp5kyjqwd0JymAOJuSi+pIo=; b=TD/HKHJjUbYWayrfJ71uv+WZ/I F1pmjHq9DE2vnGw2GK23k5SjRzXdIvj0e91zpJYHN9uolBEzWhk54MO4emI/h4Fmzwgg4OMdGioDw qP/us4fn69pkb/S5s2iUbkR98; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:48636 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rYWhz-0028Xe-0k; Fri, 09 Feb 2024 12:38:47 -0700 From: Tom Tromey To: Dmitry Neverov Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC v2][PR symtab/30520] gdb/symtab: fix the gdb.cp/anon-struct test References: <20240123170325.752251-1-dmitry.neverov@jetbrains.com> <20240125084404.3536456-1-dmitry.neverov@jetbrains.com> <87y1bw9g3b.fsf@tromey.com> X-Attribution: Tom Date: Fri, 09 Feb 2024 12:38:46 -0700 In-Reply-To: (Dmitry Neverov's message of "Fri, 9 Feb 2024 17:32:33 +0100") Message-ID: <87v86x77i1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rYWhz-0028Xe-0k X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:48636 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCMFWEQDAhOlN24BCvLTICRRdMuOBPhNq9p2iSyKzrv+jvVPbmBP6zQ3qxj1mn6qOcPgZKJFF8uwMfzRdyzPU96Iy2slkPisJ8IwVU1Gs5jCFjzYzWEd vwar9MCyD3an/a29pY9/JBS5AsKKHTJGY9vWFS30D0FAYt1fI+/fwryFDAaaV4xo3XxU/7lRSDtNUCVnKiHbxhcqqKJM1W4C+4o= X-Spam-Status: No, score=-3016.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org >>>>> "Dmitry" == Dmitry Neverov writes: Tom> Dmitry> The symbol_name_match_type::SEARCH_NAME cannot be used because Tom> Dmitry> demangle_for_lookup_info doesn't initialize a demangled name Tom> Dmitry> for it which makes a subsequent name matching to fail. Tom> I don't think I understand this comment, but anyway shouldn't this patch Tom> simply be folded into an earlier one in the series? Dmitry> Sorry, this is the first time I submit a series. I've noticed a Dmitry> test failure after I sent patches and wasn't sure how to update Dmitry> them. What should I do in such a situation? Create [RFC v3]? In this particular case, since the patch is updating an earlier patch in the series, what I would probably do is combine the two patches -- and add a comment at the spot explaining why FULL is used rather than SEARCH_NAME. Tom> I read through these and they seem basically reasonable to me -- in line Tom> with what I was hoping for. There are some minor formatting issues. Dmitry> Sorry, again. I've tried to follow the code style as closely as I Dmitry> can, but have missed something. I will try to be more careful Dmitry> next time. If there is some formatter I can run - please let me Dmitry> know. Sadly there's no formatter. We've tried but haven't found one we can all agree to. The main stuff to look out for, IME, is: * braces on their own lines (like the patch we're replying to has an issue with this in the context) * operators after a newline, not before * no trailing "(" * space before "(" Tom> You didn't mention what testing you did, so I am curious about that. Dmitry> I've done only manual testing in the project where I can Dmitry> reproduce the problem with slow symbol lookup. I'm not sure how Dmitry> to write an automatic test checking that CU is not expanded Dmitry> unnecessarily. Are there any existing tests checking that? Hmm... I think maybe gdb.dwarf2/debug-names-missing-cu.exp does this, after a fashion. For a new test you probably wouldn't need the DWARF assembler stuff, you could just translate a simple test into testsuite form. Anyway what I was really asking is if you ran the gdb testsuite. Thanks again for this series. Also, did I ask about / did we get started on copyright assignment paperwork? thanks, Tom