From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KkcJJbo0cGag7DoAWB0awg (envelope-from ) for ; Mon, 17 Jun 2024 09:06:02 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X+bKTLI5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7F7661E0C1; Mon, 17 Jun 2024 09:06:02 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5D97D1E030 for ; Mon, 17 Jun 2024 09:06:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB1B93858433 for ; Mon, 17 Jun 2024 13:05:59 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8E0A33858D29 for ; Mon, 17 Jun 2024 13:05:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E0A33858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E0A33858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718629540; cv=none; b=RrZQANaQ/n0+LCpZwXnX+Wqcp6H6qevKHbwfEhD2OUTe+5JrJzQ+EvtSYVPUPUuFlq8+/sv6iObs4xnNiwBA441hoRrlnYLZAqVbuzWuko+dlsB8OVHQbWjosBTLGrpOFIO74LdxjUVtBlM4ZVg+N+3tBQkmG/bYKyKF+wlCdPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718629540; c=relaxed/simple; bh=ibjMXgRSryrLFtLHj95C9gRhJ9UHtJ/f0VnKvo0lp6M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=DyneS2J5KaIHQXwUB9YOyzlBpQYsGw7BFT41uArhsAt8WZ24decdM/YjT9Mspl1WxyvuVXl5FTbY8yqhAQV9/ogXPtscBOwez72BB3TKu4v3y5Ib1/d7V+l+FyWN6bs/yjW8000BwqmZ1yU7+ooXviiLXwM961hYechEj0fJ5Wo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718629534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NUn7994HYCp0f+3sIE6gopTg3YR4gZwkT3eBg6B5ivY=; b=X+bKTLI50m+d8ar8gEJS27EA2xQSefkX5DX/oPUJ/L3gH3ooibBV3Z0hSBV+BYw11jiKnn 6Ek3KYddNaItLwBmYZigthQ+fQ+asStRNS4Hp6lGim+UIF4o+EoGK9BB4IfUkJvw+n42PW CGmf6GlNYXVPviKeGvA/VsZD5nNonLU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-oo5tk2wvOXuhGWmEYIAc3A-1; Mon, 17 Jun 2024 09:05:31 -0400 X-MC-Unique: oo5tk2wvOXuhGWmEYIAc3A-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35f1f29ccefso2291861f8f.2 for ; Mon, 17 Jun 2024 06:05:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718629528; x=1719234328; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NUn7994HYCp0f+3sIE6gopTg3YR4gZwkT3eBg6B5ivY=; b=XfUn58Fe0Qs0mey1lqOxLtHMKKiWaVqPUQVy82uFuVhnFRgnrpsqnZUQxJiyd12Myc lTNkroCbf0jO6cYRjtqZBpCZ6/BvB1pAnD0lpSB9Vg3spGmu7OT6SJ7/X8tAzHNUUD3s kcEE5CFa24gYuyRslqYXAY1WBvhI2JRxZTKDJcZFtYrGvdFWcWbjhDhjioEHMQQ9taHK CPvendZ96gCJii8Kz4ydGsWwvUtd6trgLRrDbqEcHB0T6o2RqsxM7vp4TWZqGIFqvr4I EjEeJfMEFEbGCecT6qVXc3FCaZQx7la3Ces/znRSatua9T+SYosB0bHMmnXkVXvcZ/Kn s0WA== X-Gm-Message-State: AOJu0YzIdT8fCXoif3Bjwjkof0v5rkVJGHYoZ5MJrcHgMwyQstFbsxX6 uuK9zZvXGkAaS3V4JRJOFt/BQqzkGlEgn7UH+++wSU78ZxcFL4P2ArjYgEWcL2u5pjVcr8K6Acr 1aO+7We1lV4ZNf1XTAED+G4Zg4zPru597z5KQqJHi9rH6tMOdfzVoe3dmbbEcfC2xjio= X-Received: by 2002:adf:fe87:0:b0:35f:ed0:9582 with SMTP id ffacd0b85a97d-3607a7b606cmr6411143f8f.16.1718629528409; Mon, 17 Jun 2024 06:05:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkjgs33BYOeP//m+vAB7u4100kETtUqUwTUC1m3F3RRYAwetN6LgWQx/K1tZYCuWXgj+RI5w== X-Received: by 2002:adf:fe87:0:b0:35f:ed0:9582 with SMTP id ffacd0b85a97d-3607a7b606cmr6411118f8f.16.1718629527831; Mon, 17 Jun 2024 06:05:27 -0700 (PDT) Received: from localhost ([31.111.84.186]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-360750f22absm12051557f8f.79.2024.06.17.06.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jun 2024 06:05:27 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3 1/7] gdb: split apart two different types of filename completion In-Reply-To: <878qziniy7.fsf@tromey.com> References: <878qziniy7.fsf@tromey.com> Date: Mon, 17 Jun 2024 14:05:26 +0100 Message-ID: <87v82767op.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Unfortunately we have two different types of filename completion in > Andrew> GDB. > > I am coming into this thread pretty late, so sorry if this has already > been discussed -- but did you consider changing gdb to have a single way > to pass a filename to a command? > > It seems to me that a change like this in a major release would be fine. > And, it would only really affect the minority of users who use weird > filenames. > > I suspect the current unquoted filename cases can't really handle > everything correctly. For instance, IIRC the gdb command processor > removes trailing whitespace -- so files like that are impossible to give > to some commands. Yes. My plan would be to merge this patch which means that commands that accept quoted filenames will correctly complete quoted filenames, and commands that don't accept quoted filenames will continue to offer completion, but with some improvements though still not perfect. With that done I can then move forward on multiple fronts, I'll work towards adding filename options to GDB's option system, this will make use of quoted filename completion. In parallel I was going to start moving all the commands that accept filenames over to accept quoted filenames. I didn't do this first as I really didn't know how much push back there was going to be on such a change. If you're rather see all the commands updated first then I can for sure get that done. Just let me now. Thanks, Andrew