From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UCcIA59mBmjiYD4AWB0awg (envelope-from ) for ; Mon, 21 Apr 2025 11:39:11 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=JW9J4wtT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 086CD1E0C3; Mon, 21 Apr 2025 11:39:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7509E1E05C for ; Mon, 21 Apr 2025 11:39:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 18F613858C66 for ; Mon, 21 Apr 2025 15:39:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 18F613858C66 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=JW9J4wtT Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 5F1363858D39 for ; Mon, 21 Apr 2025 15:38:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F1363858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5F1363858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745249916; cv=none; b=pQo8lEE3n/q8iao2w0AZGYBPGvrPtmUCTsNepNsy3qEMG6zWtdwWorLH3PI008fqwTbk2OGbdSSdnKKWIizJ/pCkJTsNj8+NRCogypHg9HphSS4zFO+LAeDfWsDz9EgguJaKYX6eFrOg23eJfd1Roj/g4NL31r5xaLdvYxGmmGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745249916; c=relaxed/simple; bh=VVl/nPsVP9/YOZMaGzPXPBrmrFgryDltGzLnSGuKxNI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=p8P/jAKrue2dl4TfK3TLk154TGEP4fe+fB5YH4HKyaMMO5Xkvtjckz6rM3NWz2qehqir/4PARzO8O9uOAI0nN7jGgiB2hoDTKEImxx+iFfmuWUtdwv50Y8lSYQPGSXi/DY20Xj552Qn6LNOp81k25PrMjaAd82v80TsybYF9lXs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5F1363858D39 Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id 6ddsuURhPiuzS6tEBu7Cc4; Mon, 21 Apr 2025 15:38:35 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 6tE9uP7K4h9Zx6tEAu2GWO; Mon, 21 Apr 2025 15:38:34 +0000 X-Authority-Analysis: v=2.4 cv=GODDEfNK c=1 sm=1 tr=0 ts=6806667a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=XR8D0OoHHMoA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=GljpK6Vf8YGs6G4_JcoA:9 a=b4DR9a7p2ZdsqdHBznES:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=RhOQ8kGoTg2Bzo+csOC47D+/yiR7yhp7ctC6FsYWorE=; b=JW9J4wtTA9R7/4hB+7gtHRDU5P B0RI4adMqo/xFcLrJ7GzaKkxlnPtsa8qh9F0lBPki0hCi41CsZ8XuNKHeNhjyQyV5Q6h0dheS0sne at1VV8mktPDIasao8z1VCkB2P; Received: from 97-122-115-172.hlrn.qwest.net ([97.122.115.172]:46920 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1u6tE9-00000001OsV-23vS; Mon, 21 Apr 2025 09:38:33 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 09/28] Remove dwarf2_per_cu_data::mark In-Reply-To: <83b9f38b-22f0-476d-b2dc-0501b41e2738@simark.ca> (Simon Marchi's message of "Sun, 20 Apr 2025 23:09:06 -0400") References: <20250402-search-in-psyms-v2-0-ea91704487cb@tromey.com> <20250402-search-in-psyms-v2-9-ea91704487cb@tromey.com> <83b9f38b-22f0-476d-b2dc-0501b41e2738@simark.ca> X-Attribution: Tom Date: Mon, 21 Apr 2025 09:38:31 -0600 Message-ID: <87v7qxwmmg.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.115.172 X-Source-L: No X-Exim-ID: 1u6tE9-00000001OsV-23vS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-115-172.hlrn.qwest.net (prentzel) [97.122.115.172]:46920 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPDsOVvB60lzccXev47Jt22uW0wgi7hO8BnhNZgEHnXlA3ATFFWd4BSCgsaK/i5mEE66rVGpyuYpdDYipBTkFBdXZKCdiusUcn4Jq30jmFW0eHAlggA0 P3BM9srMqxs4VQ3v0jjjC3QTMGWSyZYofRk4gmnlMEhkD5L+ljQnRVhA+qiTu3VsJ0IlJuBzoXIfmXqksUZYKsiMyya563qCzZw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> Can you choose a different name for these "marked" parameters? That Simon> name doesn't convey what a mark means. Perhaps "visited_cus", or Simon> something like that. I used cus_to_skip. "visited" won't really be accurate by the end of the series, because by then a CU that's already expanded will still be searched. Simon> Also, does the "marked" in "dw2_expand_marked_cus" have the same meaning Simon> as the "marked" that changed meaning in this patch? If so, does this Simon> function need to be renamed (does it do the opposite of the what its Simon> name imply now)? I think that is what it mean, and furthermore the function seems mis-named in other ways, since it isn't primarily concerned with marked CUs so much as deciding which CUs to expand. However I would rather not bother to rename it at this point, since it's deleted entirely in a subsequent patch in the series. Tom