From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4J/XGy+RCmiovgMAWB0awg (envelope-from ) for ; Thu, 24 Apr 2025 15:29:51 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=HqF2S3Q1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6E5CB1E0C3; Thu, 24 Apr 2025 15:29:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F266C1E089 for ; Thu, 24 Apr 2025 15:29:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9FCF13858C2A for ; Thu, 24 Apr 2025 19:29:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9FCF13858C2A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=HqF2S3Q1 Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id CB5943858D26 for ; Thu, 24 Apr 2025 19:28:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB5943858D26 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CB5943858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745522936; cv=none; b=kgGL8m5rmoeUf9/yyX8NXog1WENvnZUjb5pWRlhv36WJjtYklckLJbwfiYuf3vJ+4JfhkwH5rYX6aMsXoJDobYgOV6Xk3wlmLxESia08wt3TjZ/MfM1tE0t8kihvuh45ZaQORAlMgE9i5G70CC3rXeWuj9WKtv7YfCnOz2+2ZoA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745522936; c=relaxed/simple; bh=nLuK1OcUzjaterGumXg7dPAyEnWJvq4UK2v1Q6ZRqgs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=li5LuksOd4nBgyeQuYLda5aDs/REa4LwgK5y9vsz0ERujwlBglEtap/ycgD1cmLJWcnmSPD4VNmR+li2S8HzYLYmZeYBJVcyPAafAUHydlAy47nodoXQshQQRy87O4RUrvyWFBEJ96wH9uMP9Sl4yk2Q3Pq73Qa+KgwBkh6cebU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB5943858D26 Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id 81KluMTlXXshw82FkuTL8r; Thu, 24 Apr 2025 19:28:56 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 82FjuUPrrrsgD82Fku31sE; Thu, 24 Apr 2025 19:28:56 +0000 X-Authority-Analysis: v=2.4 cv=TNGOSEla c=1 sm=1 tr=0 ts=680a90f8 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=XR8D0OoHHMoA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=_vziZ_yUTDDLZsqw0T0A:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=C9ns2/bodmemSayGxr4W6b/iD2UEe/OJt3kUIKszf7U=; b=HqF2S3Q1G0PraRBpJt/cy1K0dd iXya+pbfBdo3bpKZeJt8iCGUJLL5id6DOR1M68tU3FTebr2GWAjKIvu3WxDbXUlo/AeV0Qhjf6BO7 05ALr0J9wkxHXyzxJdlq/3gCd; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:33542 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1u82Fj-00000000rlT-0pet; Thu, 24 Apr 2025 13:28:55 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: fix some flake8 F824 warnings In-Reply-To: <20250424184837.2257885-1-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 24 Apr 2025 14:48:32 -0400") References: <20250424184837.2257885-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Thu, 24 Apr 2025 13:28:53 -0600 Message-ID: <87v7qt4ave.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1u82Fj-00000000rlT-0pet X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:33542 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLZLdPdI6AIawCDYN5hTmNWG1rV47KHoyE3DbfEQlXpt/VtBXnTf3jUUXt6MJbVgCMDWcE1tgSqMuScTLbfhVo2E2UXEKG0QfZbn/EYgDfHQL+S/kJ8w vCLymSXWefo4MEf6HA3HDxgPgbqK7e4DvPdRWqpe2cpTrqrKe527fV5MjMgTPlLRRauN7soIdklubvy3QfcW9GqEfNHjsSyQ1AA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> flake8 7.2.0 appears to have this new warning: Simon> F824: global name / nonlocal name is unused: name is never assigned in scope Simon> It points out a few places in our code base where "global" is not Simon> necessary, fix them. I'm mildly meh about this since I find "global" easier to follow, but at the same time I'm sure we use this style in some spots already anyway. Approved-By: Tom Tromey Tom