From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AO71FsNpN2hoRDgAWB0awg (envelope-from ) for ; Wed, 28 May 2025 15:53:39 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dULvfs8c; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5A0B31E11C; Wed, 28 May 2025 15:53:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DCDA61E102 for ; Wed, 28 May 2025 15:53:38 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FAD9385C6DE for ; Wed, 28 May 2025 19:53:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FAD9385C6DE Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dULvfs8c Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 3C7BB385609E for ; Wed, 28 May 2025 19:53:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C7BB385609E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3C7BB385609E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748461980; cv=none; b=eHr27+hVq8tVXZC3Hf7skVqUyNvTI72RyUsSU3aTsMg3UmyT035z3Dp56a+NX/NuF7GgrXGh3chtVy02hmTFFcDkmNpRpNu4eGCuaJRKnt/ZNCSbQryXb615s+RrTJLeDCwpS7VL5UDmlwRbcXi3pxwLQjsosqNmlQ2Sl4Ymjkk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1748461980; c=relaxed/simple; bh=mBSoplidaGJPH1iyRjnND4RVN4mfxhf9WYKNTQsYxaQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=uvFvXe7f9FfeoanUo5uexrfiotjjjcblu6GEmEVM09u1OGpSh5vUbMQ+pdUuM5u770fuCeQxpWmM65/ZItxQy1lgwdvpiTq+ViBNd9pRUte1evNCV35ue/sgIg25dDX5DRWlGkhZEQad+/ptilhZWClNh+08ioFa9dSgmwTSwyo= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3C7BB385609E Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id KHOSuOXMVVkcRKMpfudNnk; Wed, 28 May 2025 19:52:59 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id KMpeudALhquerKMpfu38gZ; Wed, 28 May 2025 19:52:59 +0000 X-Authority-Analysis: v=2.4 cv=KLxcDkFo c=1 sm=1 tr=0 ts=6837699b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dt9VzEwgFbYA:10 a=ItBw4LHWJt0A:10 a=T_Alst9gAAAA:8 a=bJWTCI8Jo6YuWMMuBkgA:9 a=DvZ5ixILWSEuw56YIEpp:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=78fcVnfKKMzbT9C/DRlaBaFZwzPaHBQ81BY7kBdbb/A=; b=dULvfs8cQ0DrzGWriVmfdIrqp1 JiMlD6cMOEJilAcyfmb2EN2Vy2kU/FMvAfeWdZ+y5oN/PYUkEFlvDGv/BLcBGPmdnVIFSy+Vp5Tds wk5CqG6G3aZlRMgcT7Y+83sKf; Received: from 97-118-46-156.hlrn.qwest.net ([97.118.46.156]:43186 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uKMpe-00000002y7H-1IOl; Wed, 28 May 2025 13:52:58 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 37/47] Windows GDB: make windows_thread_info be private thread_info data In-Reply-To: <20250519132308.3553663-38-pedro@palves.net> (Pedro Alves's message of "Mon, 19 May 2025 14:22:58 +0100") References: <20250519132308.3553663-1-pedro@palves.net> <20250519132308.3553663-38-pedro@palves.net> X-Attribution: Tom Date: Wed, 28 May 2025 13:52:56 -0600 Message-ID: <87v7pkecmf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.46.156 X-Source-L: No X-Exim-ID: 1uKMpe-00000002y7H-1IOl X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-46-156.hlrn.qwest.net (bapiya) [97.118.46.156]:43186 X-Source-Auth: tom+tromey.com X-Email-Count: 26 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCZHo4P7r/4rhJKp+QBQO2+CuHrmVaiL8qZFCyv2HoGAXg37k/HVSsu4C8nqM28WBmeuptZMeJuUDXgnELYm4mfckgeqQeu+N4chIVK4RP2d8Z/k2PP/ LufCQze7+9Lwgos0pUIX6/2UyJQgd8eYjBPAb9ix0CoqI5bDXYH2MxjnNRhwMUXKNbMJ5KmlsxIADe7h2fTx26sSdg/kAD1jcrE= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Pedro" == Pedro Alves writes: Pedro> When that is supported, and the core wants to be notified of thread Pedro> exit events, the target backend does not delete the thread for which Pedro> the event is being reported. Instead, infrun takes care of that. I did not know about this detail ... is this documented somewhere? Pedro> Fix this by eliminating the parallel thread list from the Windows Pedro> backend, instead making the windows_thread_info data by registered as Pedro> the private data associated with thread_info, like other targets do. Nice, thank you. I was a little worried about possible conflicts with this field, but searching shows it's either used by the thread layer (aix and linux) or by the -nat layer (darwin and remote). So it's reasonably robust I guess. Pedro> +/* Get the windows_thread_info object associated with THR. */ Pedro> + Pedro> +static windows_thread_info * Pedro> +as_windows_thread_info (thread_info *thr) Pedro> +{ Pedro> + /* Cast to windows_private_thread_info, which inherits from Pedro> + private_thread_info, and is implicitly convertible to Pedro> + windows_thread_info, the return type. */ Pedro> + return static_cast (thr->priv.get ()); Should this use checked_static_cast instead? Pedro> +/* Creates an iterator that works like all_matching_threads_iterator, Pedro> + but that returns windows_thread_info pointers instead of Pedro> + thread_info. This could be replaced with a std::range::transform Pedro> + when we require C++20. */ I was going to suggest a note in the meta bug but I see there's already a note about using the range library. Tom