From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VKw+Kgu/VGglThUAWB0awg (envelope-from ) for ; Thu, 19 Jun 2025 21:53:15 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=cZIBmZOQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9B8C91E11C; Thu, 19 Jun 2025 21:53:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 290FB1E0C2 for ; Thu, 19 Jun 2025 21:53:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 945FB3856DFD for ; Fri, 20 Jun 2025 01:53:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 945FB3856DFD Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=cZIBmZOQ Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 866C83856DFD for ; Fri, 20 Jun 2025 01:52:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 866C83856DFD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 866C83856DFD Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750384337; cv=none; b=YIwR5a1BekuggwHeprkO2NDNEoM7lbREJmd6t5QvqEFJaAt9famvCi5PNxK4mHkXvfavk7Pt+5IbEj908BrPsWoeTwveCtdMl4CckO/KZblhtVhKG+m2PuY4UVnGjR8gOtPIuW6VDdYIraYoFCNVFNbHkJ2oACFbYgBQf0jru5Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750384337; c=relaxed/simple; bh=74dCIhipWkHWzLszSI9OcvcNTWB9Zpy7lLsAzOWK9zs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gqafphnoaYM+waFj/8+nd4Uj4DhiqUagBQxlEqzMY0tv+SPjro200XbxndU0ydLGBo42w657m7+PstN6w/+8PaR9Un+szRuC/kLAMDydGIa+ioSPO0pS+yDvR8JKmaQecsLZ7vv/Zu/2tKnkU5eMYCXl2dqFpeXBVtybdwVlUbc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 866C83856DFD Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-b170c99aa49so909121a12.1 for ; Thu, 19 Jun 2025 18:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750384336; x=1750989136; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xYMBF7BgYalg0PLNie0sqW/QVj98CjF6Fk5wa1Wa9iQ=; b=cZIBmZOQ+ahkN+G5e9wjxzPuuyLceJ06Y64+kCDHgw2rBw9t3TgkGkN26on6BBU035 eHefd7IYScJVi5WeGYK00znnPCGswO+whgl2mD+oane60JtRLN/9q5cZGi5h1KrpAEku 188ZpFUaLuGFuuiiveNIYjup1hIW1KUqtUcxTgv0y8go6CdBEu2sVpMLARxLd5GPvpkK /TzqcWE3XX2tciSC+FQRdWU3NqTPFH8l81Xrx/pGHLMnkPAeC7gW8V+nc1QC+IZ30mly SJlCYyKKnW7AYuI4N14rZCjvVJezCYUoc2lDX6JcIwJKLu1GhEewEA+6/Hq0Z4Ygh+qn Xd2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750384336; x=1750989136; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xYMBF7BgYalg0PLNie0sqW/QVj98CjF6Fk5wa1Wa9iQ=; b=PeIF2xT9p1gN07WLyvE27h/Io9v7yFqJ844Z5aElayj37YLfXZ2m/ITYiVcnbsib3Z 0EorakmNO1sa9KHOLwff3Pat5Tsm6e63t8aeGRPPRfJby4YYoEHgM1SqQXQLDyjMsDxi 6Ohm2jwZyIsDn2gco4RcqGCt3D8g1/8bxjcjTInSD11v8+lD7j2LZEu9uZ9v4I3J5eQR c07JA6UvXWlE2D0x0k2dPDqLge/x0yDuRrHbSrE2DKxgkoi7GrKzaifUDaALglRSXhyZ mZSFMaqyxIEkFrmUyyJHP3popHtC5kEGlVgdhwq166mKZAi2BniZaAVuQ5e6klTXTcjK 9lYw== X-Gm-Message-State: AOJu0YxqNA2UyhrHswjBeWhLOc3JXwJfdAf5HyZvV6I2QW8sUOE+f1Pn G19zmYN1qGbC03KAe1taZGn7JnIwGM49RTqu5Pjv5fGxwCTu0Zi71h8oikrqtSFSSis= X-Gm-Gg: ASbGncsDMuEeCwhi3QoQF2dPhey1dM+azSm5Kw4WgJNBl3mYit1ErgQnBHl4E2U/+p4 4X+F3BqKcAAeRKw1SjGIiKUvEmumJRkU/2W+fecBFficb2hu8HOHmHlth8vFPU4FuyK0VzL6ZQt 62W1PEYg6giy5A/Pp4UN7efu91oeDds4vyrzUmL1Kqtaa58qnGqzGgq/6kJBUGNfIuPeNnJ2cGN fm0yKEouXwL56cuzePdVdlxtMTWsrGmtysAE2POR0DWoqKiHrguiMw1Jotaz3aKrmhFRNJ29XQG v2F0HxGWFmLF6ZVORkGWrrCC2chm26+mIBLb4E3WPEpmTL0mOR03sASC6QWc88hY+1OBp5ZT X-Google-Smtp-Source: AGHT+IGlEwa2tPfLbHHEua8wbXPWQ3yeJAohlXEawR+56d46HYLlBJeYBXXDQ+yITU6umCSQ78jQmA== X-Received: by 2002:a17:90b:4b42:b0:311:d670:a0e9 with SMTP id 98e67ed59e1d1-3159d8c603bmr1750844a91.21.1750384336410; Thu, 19 Jun 2025 18:52:16 -0700 (PDT) Received: from localhost ([2804:14d:7e39:88d6:5445:e80d:c771:b2da]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3158a23e640sm3022114a91.15.2025.06.19.18.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 18:52:15 -0700 (PDT) From: Thiago Jung Bauermann To: Christina Schimpe Cc: gdb-patches@sourceware.org, eliz@gnu.org Subject: Re: [PATCH v4 07/11] gdb: Handle shadow stack pointer register unwinding for amd64 linux. In-Reply-To: <20250617121147.1956686-8-christina.schimpe@intel.com> (Christina Schimpe's message of "Tue, 17 Jun 2025 12:11:43 +0000") References: <20250617121147.1956686-1-christina.schimpe@intel.com> <20250617121147.1956686-8-christina.schimpe@intel.com> User-Agent: mu4e 1.12.11; emacs 30.1 Date: Thu, 19 Jun 2025 22:52:13 -0300 Message-ID: <87v7ornprm.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hello Christina, I have one late, small suggestion on this patch. I wouldn't have mentioned it but if there's going to be a v5 for some other reason then it might be worth making the change, if you agree with it: Christina Schimpe writes: > @@ -3036,6 +3043,46 @@ show_dump_excluded_mappings (struct ui_file *file, int from_tty, > " flag is %s.\n"), value); > } > > +/* See linux-tdep.h. */ > + > +bool > +linux_address_in_shadow_stack_mem_range > + (CORE_ADDR addr, std::pair *range) All callers pass a range argument, and this function doesn't even check if the pointer is nullptr before dereferencing it. For such cases, using a reference rather than a pointer is better, since the compiler will make sure that the argument is never nullptr. > +{ > + if (!target_has_execution () || current_inferior ()->fake_pid_p) > + return false; > + > + const int pid = current_inferior ()->pid; > + > + std::string smaps_file = string_printf ("/proc/%d/smaps", pid); > + > + gdb::unique_xmalloc_ptr data > + = target_fileio_read_stralloc (nullptr, smaps_file.c_str ()); > + > + if (data == nullptr) > + return false; > + > + const std::vector smaps > + = parse_smaps_data (data.get (), std::move (smaps_file)); > + > + auto find_addr_mem_range = [&addr] (const smaps_data &map) > + { > + bool addr_in_mem_range > + = (addr >= map.start_address && addr < map.end_address); > + return (addr_in_mem_range && map.vmflags.shadow_stack_memory); > + }; > + auto it = std::find_if (smaps.begin (), smaps.end (), find_addr_mem_range); > + > + if (it != smaps.end ()) > + { > + range->first = it->start_address; > + range->second = it->end_address; > + return true; > + } > + > + return false; > +} -- Thiago