From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Hcc4H4uKbGj0WS4AWB0awg (envelope-from ) for ; Mon, 07 Jul 2025 23:03:39 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ga11PDoN; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6C9E31E11C; Mon, 7 Jul 2025 23:03:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 812FA1E0C2 for ; Mon, 7 Jul 2025 23:03:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1D8B9385B805 for ; Tue, 8 Jul 2025 03:03:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D8B9385B805 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=ga11PDoN Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by sourceware.org (Postfix) with ESMTPS id A3804385AC1E for ; Tue, 8 Jul 2025 03:03:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3804385AC1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A3804385AC1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751943788; cv=none; b=qnAVAvxxKlGzu+qjkRVBl2FbFX8ivDTI5WTXcADeEb0z7wtottqH2+uUyY0VyRXqfC4Cp8Es8xJ9jAMbpe2mN1/Ua/QMvtl6a+8VHGpT0XapNlViB7MU7fRg/Xo0blVFY4+xVUoHUOKosECaMYfWfxI+EWgnndyYytKGq0AzGqA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1751943788; c=relaxed/simple; bh=uspTw01NbNxkibsLhcniLQ1HEXLngJIhRpP8AY8Ecuc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hAoCDeNXsG5uL/FE1UnjI32UzeAfRMfHTvyM9m18afbS7NXGIMY5R16WHaHM99MikA5qLORbqZHnNRrR7u9So4HaldOPmhTIncYC/BNR5JLoPDfWRv2kqgQyb3J4DYuBTA5h0sSaBRCM+r9DMj2G1FA2GOtS8niHTufHPiaT+/c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3804385AC1E Received: by mail-qv1-xf35.google.com with SMTP id 6a1803df08f44-70109af5f70so38986046d6.0 for ; Mon, 07 Jul 2025 20:03:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751943788; x=1752548588; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=SIZVEX6RfZZ4QwZ0nSeeG6cGfQVcndkIoqHJC4XQ1G8=; b=ga11PDoN4Ryy61k34fkp/44NGhqgrF9B7uWRbUVhDp4mmVesRdyjBG2XCIoBjvr078 VmVZsuduaNqsXUPjegJ/UjRG73GirYkokdu2N5Sqaq/mYrgX/eeKdrVKKT7boBKJeZbw ygKFT2WoNcRbdxXnrfHl2zUdvS/bdm5dVuiYRmHkncEvOx00vAPWUXyFRV0BRI/pyza+ bUcEkuIuwV4OujK8OteMdllCZtogDTB7RxEdFff9gEXOFhroHaMa2QFfueuInMPGDeIc wo//C3ff5/Hwe7xNcG6wXGL5CJBajyGPqXIwBzpEBo2BSkN+pMuT4Tgyi/iSyFo5/Noq zlGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751943788; x=1752548588; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SIZVEX6RfZZ4QwZ0nSeeG6cGfQVcndkIoqHJC4XQ1G8=; b=r5oVVD00yxCz9tIXVCy1n6HKIU5Ar6VT69E9NzJGoLSBPSpRt1BkoROyDEPBdIpNvC isB7TJx7ZHk9jtDQLne+WMHTBU6ZBxKXVHa7QgGZdC4hdAeYkR4L7fGLZwKYIGZ7Qca9 Z7HGQOtaGID4IDfAa5LZjKqU/7FoQQ4VgAa0bfSTVceBykqsFAzTgIth0Ok4v50GcLCl u91dn/Sz3XHyc6ZftF/ykjtx/VFF85TkTA2Tbu+6FNoBBAuiKyHxIJqSZLYFcgJ+IXXx EaICM4LKDQMVTDtP0y2QCwe/QKdClLnMb1neU4npR0koTpVYS2Sio2ouwSd9mBmXLrvx lHqA== X-Gm-Message-State: AOJu0Yx/dfk/j3eXb/+5465i8Gi3dQU3sJ3rBfFqsgkKv4+VxTC5db3D WvQJ9GQd7hrwpXqBEwNooTCxLoczXpHbyUVKy+P5tI4W8dxt3i9lyuE+j5dhK/nJtCSBztSSIrw uePFL X-Gm-Gg: ASbGncv1wOyFIeO9LySwITetz9pyzsek1VDl4f17/+Zw9t7RzqrsNSgcA94khQs1pYK rSAUW2onOqseXnJ4goJBuA8Is9bChQ28U/tDHai5qC66ITqTEZprbqvMO+XzDZOQDGnRG1xeZbJ vg4DmZGF1oWyFLcEsr5HmgzE1GEnOmNpHXa1Nht3ASZUkqFSm/nXEShGk9lm1Qw44//Lowyf7Tb 09fhrRuhUiDVVWmxw0rYSRFimg0EgZqnN8CqQHgLjBIvCoIbDoISeS1xxhvJ2XBpWWLBuZrJI0b XDQx3/QSbEMl7m3r3TX1bV4oai5braQzLAEmPOX0VuA/F//eaw4H4JRhpEwInfk3ymSdxpg= X-Google-Smtp-Source: AGHT+IHIcAU80TF9K2So2trXRliWxfE/C8MKC9C3fNVvGhzuUYZE1D4prWL0n/MjlCdd6uwV1ezT2A== X-Received: by 2002:ad4:5ec9:0:b0:702:bf0a:b9d8 with SMTP id 6a1803df08f44-7047d94868cmr18177766d6.13.1751943788005; Mon, 07 Jul 2025 20:03:08 -0700 (PDT) Received: from localhost ([2804:14d:7e39:88d6:eed:782a:14c2:417a]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-702c4d5ad3csm68765356d6.89.2025.07.07.20.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 20:03:07 -0700 (PDT) From: Thiago Jung Bauermann To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org, Markus Metzger Subject: Re: [PATCH v2 05/47] gdb, arch, intelgt: add intelgt arch definitions In-Reply-To: <20241213-upstream-intelgt-mvp-v2-5-5c4caeb7b33d@intel.com> (Tankut Baris Aktemur's message of "Fri, 13 Dec 2024 16:59:22 +0100") References: <20241213-upstream-intelgt-mvp-v2-0-5c4caeb7b33d@intel.com> <20241213-upstream-intelgt-mvp-v2-5-5c4caeb7b33d@intel.com> User-Agent: mu4e 1.12.11; emacs 30.1 Date: Tue, 08 Jul 2025 00:03:05 -0300 Message-ID: <87v7o3s7ti.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tankut Baris Aktemur writes: > From: Markus Metzger > > Provide Intel GT architecture-specific definitions that can be used by > both the low target at the server side and tdep at the GDB side. > > Other than, for example, IA, Intel GT does not have a dedicated > breakpoint instruction. Instead, it has a breakpoint bit in each > instruction. We define arch methods for dealing with instruction > breakpoint bits. > > Co-authored-by: Tankut Baris Aktemur > Co-authored-by: Mihails Strasuns > Co-authored-by: Natalia Saiapova > --- > gdb/Makefile.in | 1 + > gdb/arch/intelgt.c | 77 +++++++++++++++++++++++ > gdb/arch/intelgt.h | 175 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 253 insertions(+) Just one nit below, but regardless: Reviewed-By: Thiago Jung Bauermann > +static inline unsigned int > +inst_length_compacted () > +{ > + return COMPACT_INST_LENGTH; > +} > + > +static inline unsigned int > +inst_length_full () > +{ > + return MAX_INST_LENGTH; > +} Not sure I see an advantage in these functions. I suggest removing them and using the constants directly. > +static inline unsigned int > +inst_length (gdb::array_view inst) > +{ > + return (is_compacted_inst (inst) > + ? inst_length_compacted () > + : inst_length_full ()); > +} > + > +} /* namespace intelgt */ > + > +#endif -- Thiago