From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EvxEOiqz4mjTkCAAWB0awg (envelope-from ) for ; Sun, 05 Oct 2025 14:04:26 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SS1eNo/p; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D9AFD1E047; Sun, 05 Oct 2025 14:04:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E7FDC1E047 for ; Sun, 05 Oct 2025 14:04:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 904B33858C41 for ; Sun, 5 Oct 2025 18:04:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 904B33858C41 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SS1eNo/p Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 2869E3858D1E for ; Sun, 5 Oct 2025 18:03:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2869E3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2869E3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759687431; cv=none; b=ocIpXbktd7OaE0pqHH+I49PCOwzKV92AIqjlteamsbVsYDYSx1+l2gpBeeVxYG5X7RHUPNbDvt9DQt5Y9Pq4ZoIA/2GXty1LaQeM5a8sN4ye7zDTByHBetFiIl5JPcn3dX/+uktmEk5fNzxM5LrvySgk0dfADM106K0OytehOkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759687431; c=relaxed/simple; bh=PExFXxN7IK70Kwd0IahnjJSVDMFOGqg8b8Rm37rF2K8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Q22t8uBH6sto8Vw7D5NaJtKk2wWI87wAtQgAzGzFpppmdmlETgXUVGBuqKVLzV3UVirgNk40s+iCXu1xjYbgUa+Rz1/hKQ5ZRmRblOFVBgvlzsJxBu0HxEre9D0qiSy0K1OQPAjVtCHBMtC5H/4nOV9o+FBWYh4OeEEGdZFMWtM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2869E3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759687430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=naVsc8agm+R6FPr3BK/LV2D0YYSD0aG0UvHjuQrEE2E=; b=SS1eNo/p272NvGaAw69oStKJ/wmL1HeT7eYKSqqHIESqXV45FuJbvmbS7/McMOL8WOAiEo K+bYqbBRlSrQmScalPCYi13D+IsNX02XqIx8RULKNVgdXRQs0ry0Hx3S0RnN3nJBR1x/5J QXuzIk18GWMdFt14jRd8d7C8inppozY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-539-nG_7jLm4N8G1zrNVMKcAdQ-1; Sun, 05 Oct 2025 14:03:49 -0400 X-MC-Unique: nG_7jLm4N8G1zrNVMKcAdQ-1 X-Mimecast-MFC-AGG-ID: nG_7jLm4N8G1zrNVMKcAdQ_1759687428 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3f6b44ab789so2153881f8f.3 for ; Sun, 05 Oct 2025 11:03:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759687428; x=1760292228; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=naVsc8agm+R6FPr3BK/LV2D0YYSD0aG0UvHjuQrEE2E=; b=AaPKPtkbbitJlY55gKDxjPCWCT8SQ+U6RUpmar9d1Bxe/2o3wmCt7tH71eJYeQFPKq NS/YPxlP+KR5IwKsP3VUO7ZreLSUFmRP3c/Ng8zkBxjWQ9wcgxkMH46ubPT8uB241IF/ uLmGDKh3Tn6uashvGdtq4N1v/xVY/uIVspUuhfPew8AHs3p86uVdrAEgGKwuxfyYduGY u007XU3p9FkSYHRi2mWZGEJo2/5AXN+MxzFjKzgGw60Z56NrlXHUhgRmOXgbKqY/CIRe /FvcksZpbvncaQnb85nh7bb/vC0eTKn3AqfW9hvtxGCaIJTe/mUHihOpX/APXm2K9z8R EGRw== X-Gm-Message-State: AOJu0YyUWgy6+TSrIAWmzez61rcsnJcPMsrUJH2+Bfdhk9leZPKDC1Zf A12OhSD49PBwyX8vurBJfFn3gt5U++RJPu5eanD+QIlPc1RKESZXaM4KM3Tgvp6mVkbSWBdi6dk 00rJkqE9RIe2kEB0xpd6Iejj5fDILQndZHBTV4U1C3IwmpzPKyWC2hh7rLXLujwo= X-Gm-Gg: ASbGncuL++FwrAvkwieKLxPlbveTvcEStFMlxWWxMbLF5NL0PPhp9Le34e0Usf6H3oD 0PVIsTsTueCPZPlKbvKCfZwylF7xgfiubEy6AVRVbsdrPSL/OhQBmeuNFpmBJ/MYQvTYFDPsSjz /uT3234GchJAGfqHxiljAFQ8dxx4gmoZCKsuzs/BAd0QUUuGUECWWI+Hr2GJe3P5FWWPyA6b7zP wa1uxpAIV0AQIHUGeVDA8WdIM9Y2Z/9sxsvgGFJ9XWnk0fMSEhCieeRGzhAVQINJyC1BWd95Oh7 EC7lV8ti9z+JNrm/DLeF4VBQFXHIiHg5Bv/B1REF X-Received: by 2002:a5d:64e7:0:b0:403:6f7d:ac5d with SMTP id ffacd0b85a97d-425671999f7mr6276610f8f.34.1759687428200; Sun, 05 Oct 2025 11:03:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGltuZCDdHClwW13PCj60Pdgde/Z6Y1I8hYQfQ9ZdnZ8PFbUBdlZM0apmx/AX/KFOF6vKmewg== X-Received: by 2002:a5d:64e7:0:b0:403:6f7d:ac5d with SMTP id ffacd0b85a97d-425671999f7mr6276589f8f.34.1759687427742; Sun, 05 Oct 2025 11:03:47 -0700 (PDT) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8f027csm17471454f8f.40.2025.10.05.11.03.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Oct 2025 11:03:47 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv9 0/3] new gdb.Style API In-Reply-To: <8ca0db41-c3a2-4192-b279-88d18e34fbd4@suse.de> References: <878qhr7pm5.fsf@tromey.com> <87y0pp7br2.fsf@redhat.com> <8ca0db41-c3a2-4192-b279-88d18e34fbd4@suse.de> Date: Sun, 05 Oct 2025 19:03:46 +0100 Message-ID: <87v7kt6xa5.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 810Yl_I3yslBKCsA-BSni8LQKnyEv0TY6VsaZJ79Tps_1759687428 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > On 10/5/25 14:51, Andrew Burgess wrote: >> Tom Tromey writes: >> >>>>>>>> "Andrew" == Andrew Burgess writes: >>> >>> [...] >>> Andrew> In v9: >>> >>> Going for a record here. >>> >>> I think these are ok. Thanks for doing this. >>> Approved-By: Tom Tromey >> >> Pushed. > > Hi, > > I'm running into pre-commit failures: I searched on the GDB wiki, and did a grep in gdb/ and gdb/doc/ but could find nothing about "pre-commit" except for one comment in check-include-guards.py, but that doesn't say what "pre-commit" is. Is this process documented somewhere else? Or have I just failed at finding it? > ... > flake8...................................................................Failed > - hook id: flake8 > - duration: 0.25s > - exit code: 1 > > gdb/python/lib/gdb/__init__.py:557:31: F405 'Parameter' may be > undefined, or defined from star imports: _gdb > gdb/python/lib/gdb/__init__.py:579:21: F405 'COMMAND_NONE' may be > undefined, or defined from star imports: _gdb > gdb/python/lib/gdb/__init__.py:612:21: F405 'Color' may be undefined, or > defined from star imports: _gdb > gdb/python/lib/gdb/__init__.py:613:21: F405 'PARAM_COLOR' may be > undefined, or defined from star imports: _gdb > ... The patch below doesn't break GDB's Python support. And based on the existing code comments, I suspect this is the required fix. But I haven't run the "pre-commit" tests (see comments above), so you might one to check this fixes the issue you reported. Thanks, Andrew --- commit 5812afb15e8b7774984c238eb67adcf6eaa704a9 Author: Andrew Burgess Date: Sun Oct 5 18:55:33 2025 +0100 gdb/python: fix some flake8 warnings related to Python code After these commits: * 49e4d0cdca3 gdb/python: add gdb.Style class * d5214580a5f gdb/python: new class gdb.StyleParameterSet * 3c724596812 gdb/python: extend gdb.write to support styled output the following issues were pointed out on the mailing list: I'm running into pre-commit failures: ... flake8...................................................................Failed - hook id: flake8 - duration: 0.25s - exit code: 1 gdb/python/lib/gdb/__init__.py:557:31: F405 'Parameter' may be undefined, or defined from star imports: _gdb gdb/python/lib/gdb/__init__.py:579:21: F405 'COMMAND_NONE' may be undefined, or defined from star imports: _gdb gdb/python/lib/gdb/__init__.py:612:21: F405 'Color' may be undefined, or defined from star imports: _gdb gdb/python/lib/gdb/__init__.py:613:21: F405 'PARAM_COLOR' may be undefined, or defined from star imports: _gdb I believe this patch should resolve these issues. diff --git a/gdb/python/lib/gdb/__init__.py b/gdb/python/lib/gdb/__init__.py index 0388c6a2c00..65f76988925 100644 --- a/gdb/python/lib/gdb/__init__.py +++ b/gdb/python/lib/gdb/__init__.py @@ -34,6 +34,10 @@ from _gdb import ( parameter, selected_inferior, write, + Parameter, + COMMAND_NONE, + Color, + PARAM_COLOR, ) # isort: split