From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZPKJJYiL5mjZPSQAWB0awg (envelope-from ) for ; Wed, 08 Oct 2025 12:04:24 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P860RT+6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 89B911E0B6; Wed, 08 Oct 2025 12:04:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B109D1E047 for ; Wed, 08 Oct 2025 12:04:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2F8143857B8F for ; Wed, 8 Oct 2025 16:04:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2F8143857B8F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=P860RT+6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7BAD23858C52 for ; Wed, 8 Oct 2025 16:03:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BAD23858C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7BAD23858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759939431; cv=none; b=axjd/fvM7bIDJtQT1bmM6A/x6lu73WilIykx6yVQ4d/6HUWxW3C3wbORD1/Y/NuKBSruHqKYzWH0mWTY+kymRKQLq2Nmy/eXC8yrbZNzW3l1cnfkpT5TESXdZfsJRenIknAvZ7APaBPzE3sCM9V6wRRgxty17JX0uHdtFUA5W0M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759939431; c=relaxed/simple; bh=iutCwLTa1cPbDCO/vM5buo4GB06/yaX2v4hAjD3wdMw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Lz7UQFs0DSISm2Lv6M6VSiIK9U9tY7SM04aItprcqdEs80JU4WL0XWoIj1RJWLTktSCpSESTNa3mhx2JA4YPF9D26s8TH7hUpAGxDy/KSE74usiyQkvUNYb4gFz/SqRO6bIza889hDUWjJ1XLm39YGwdpD7QxZ4N5dVahZ/tUwU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BAD23858C52 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759939431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4YNyt7NceNSAVOYaVlBD01VkVeEJR6UXjXw1/cMkllI=; b=P860RT+6T7jOPUIqHseFrgPMSeBEjKw9bS269jx73h/su5XJvxIjzcovxanxS32szHPMOv 4/z7pmEEynAC2hG9u8sHSkkFr1S4cs9O94a8X2ybkC9vPDkQDB7k7sfuEXl53H002Rf5Q3 y1KQU/jwts8jWgECrfEUqK0LpfRCehM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-9jv8bzIcM96Ic-M-lgsxzQ-1; Wed, 08 Oct 2025 12:03:45 -0400 X-MC-Unique: 9jv8bzIcM96Ic-M-lgsxzQ-1 X-Mimecast-MFC-AGG-ID: 9jv8bzIcM96Ic-M-lgsxzQ_1759939424 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3f030846a41so44291f8f.2 for ; Wed, 08 Oct 2025 09:03:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759939423; x=1760544223; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4YNyt7NceNSAVOYaVlBD01VkVeEJR6UXjXw1/cMkllI=; b=GTqt6VA77tGgdjWwPj0pBMmHJA3ZjcQ0+DwiWOUZn471B6Ujva+I99OUV/JnAV0bnW ixO+mO/WsfdEmwlyEnt9fl1UMD714kP1BajZaRKGDtk6PQxMWek3dphO1X1wzssKoI3J xQQjiCFVp32EDlY3xdHTSr9UrXv2yHHUQG3hYeqelE+nkTfiOLWkL1CGdwVOF6OB+z3n xzKPyAghhvfbU7VI1W0i5Etm3aZN1M3AUdZkYl1GALVoowrkH/CBH7m54K3RKZ9Fi9N5 uqIvnbARVhS+WhYsGIdHGtJ2Xot1jF+lWKPprkuKJoNksIuSkR50hRJZZHwyq0Y0aiPf jesw== X-Gm-Message-State: AOJu0YzqUbB/G9u+Sn/1zpe8HHHHBjFFSTv7EHR52c0m5iqRjQhCxAf6 cKYKBPt8vl9O1sS7W7IKrd/1bSJwDR6tIJ4B0WLrLvlgWfEIa86QTMCba/9YPfHK+ie1/0iuV6l VnfpB0KFYucdcXaRnzZw+aRy23/GutmlSZTi34/Jqx3uR6yoyWCbAfitb2xpeSGlm2VvEHz4= X-Gm-Gg: ASbGncsBzf0ZIczgGGTh8MqZDbuaNEqZe0025QLZb1/d+a89a7Y38AjMPmCX5hGkps+ i2huYGCbDgTgjkD1+HXirMYIuKuEKrm1U1hxgsk+7jilNY4E+gEBAYvdEKjjf6DaZHoYAST2xf7 m4pedIy/UjWTcc7+TVv/rdHNW05cgt5CpZG6S+WmjiuLCHW+5vGI8ox9nmv4CguP4S3LxD0XUGU JTXQp3oo45xaTadMSy9wdWKlocfEQg+pXPGgIcTz/91ojxay+od/8ulmTivPgw9kUSQzM4JGvwq HLPUFFSnuClyHuq/GbDjWV6b3IstC1wz1ZxPiPME X-Received: by 2002:a05:6000:1862:b0:3ec:ea73:a94d with SMTP id ffacd0b85a97d-4266e7dfc44mr2545962f8f.37.1759939423665; Wed, 08 Oct 2025 09:03:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHCrerH2pcJpGcGf7bQRWYHnbBGj3o1IOz7V1kY6ZvtjpOqEY3rWJddQjEQjFynhyJCzSZPhQ== X-Received: by 2002:a05:6000:1862:b0:3ec:ea73:a94d with SMTP id ffacd0b85a97d-4266e7dfc44mr2545940f8f.37.1759939423243; Wed, 08 Oct 2025 09:03:43 -0700 (PDT) Received: from localhost ([31.111.84.207]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46faf18bbe7sm4963255e9.20.2025.10.08.09.03.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Oct 2025 09:03:42 -0700 (PDT) From: Andrew Burgess To: Tom de Vries , Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2 3/3] gdb/python: add Corefile.mapped_files method In-Reply-To: References: <9ab589510f784da2752b72d0b1385afa33aca406.1758634958.git.aburgess@redhat.com> <87cy737q50.fsf@tromey.com> <87zfa26gxp.fsf@redhat.com> <87o6qi6dwn.fsf@redhat.com> <87jz166al5.fsf@redhat.com> <3996ddc9-2cb4-4ead-8895-5d6b27b5a72c@suse.de> <87bjmi65h4.fsf@redhat.com> <874is968sb.fsf@redhat.com> <871pnd5vm0.fsf@redhat.com> Date: Wed, 08 Oct 2025 17:03:42 +0100 Message-ID: <87v7kp4bz5.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 8PF8D4e1W7jb2_A1SWaBubYNZrsgh9iE5OLGJwMBeMk_1759939424 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom de Vries writes: > On 10/8/25 16:14, Andrew Burgess wrote: >> Let me know what you think. > > Hi Andrew, > > thanks, this LGTM. > > Please apply this as well: > ... > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 5dfcfefd7c1..ef6a8f859ef 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -11635,7 +11635,7 @@ proc expect_build_id_in_core_file { filename } > { > } > > # Convert OFFSET to decimal. > - set offset [expr 0x$offset + 0] > + set offset [expr {[subst 0x$offset]}] > > # Now figure out the page size. This should be fine for Linux > # hosts, see the istarget check above. > @@ -11650,7 +11650,7 @@ proc expect_build_id_in_core_file { filename } > { > # but the default behaviour is to include the first page of the > # ELF, so for now, we just assume this is on. > verbose -log "Page size is $page_size, Offset is $offset" > - return [expr $offset < $page_size] > + return [expr {$offset < $page_size}] > } > > # Return 1 if the compiler supports __builtin_trap, else return 0. > ... > to fix tclint warnings. I applied these fixes and pushed the patch. Thank you for all your help debugging this issue. Thanks, Andrew