From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QTYhJ/BbEmmr0jMAWB0awg (envelope-from ) for ; Mon, 10 Nov 2025 16:41:04 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=duo-1634547266507-560c42ae header.b=LiUGesbl; dkim=pass (2048-bit key; unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org header.a=rsa-sha256 header.s=dkim-high header.b=XbTTUuFD; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=dkim1 header.b=h3ufuxt2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9BF901E0B8; Mon, 10 Nov 2025 16:41:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C36F81E04C for ; Mon, 10 Nov 2025 16:41:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 68CD23858416 for ; Mon, 10 Nov 2025 21:41:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 68CD23858416 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=duo-1634547266507-560c42ae header.b=LiUGesbl; dkim=pass (2048-bit key, unprotected) header.d=outbound.mailhop.org header.i=@outbound.mailhop.org header.a=rsa-sha256 header.s=dkim-high header.b=XbTTUuFD; dkim=fail reason="signature verification failed" (2048-bit key, secure) header.d=stackframe.org header.i=@stackframe.org header.a=rsa-sha256 header.s=dkim1 header.b=h3ufuxt2 Received: from outbound1g.eu.mailhop.org (outbound1g.eu.mailhop.org [52.28.6.212]) by sourceware.org (Postfix) with ESMTPS id C3FDA3858C31 for ; Mon, 10 Nov 2025 21:40:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C3FDA3858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=stackframe.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=stackframe.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C3FDA3858C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=52.28.6.212 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762810800; cv=none; b=pp4XkcYBTsHBvrXXU1Khfp/nNgFwXct4Ju+G4pVwofte+ZNzOq4QQuk/GSkucGLCgkQPl+AThROxMn08nj+MDQw7Ol0oJO3AjrSa8upWq6O8O/Q8hQNB10GTcbiylxdgtjPNsvH/oBxokXi37pvPSyLMlsAT4wHpB8jCnC2mV2g= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1762810800; c=relaxed/simple; bh=NTHkyH02LuEMu0tZYxJ+vbP4pN0T+UDv4+fPsi3Ctwo=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:From:To:Subject:Date: Message-ID:MIME-Version; b=BcWFE7Yqj7MC8RAnfslm/H8H9IJFYiBMEj4uokrP9CcwEON1LQ5JXtDorOHUN2CowC10Zmu8Ipm4Pe0lQsUyRcjVM/awk4FWPtl2DCQbNey2oa6e26ozAorFKIejLQIGFQMItkXtM6XhH8QYWpPnW+DHKZh0rHgixkLB3tOnGfc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C3FDA3858C31 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stackframe.org; s=duo-1634547266507-560c42ae; h=content-type:mime-version:message-id:date:references:in-reply-to:subject:cc: to:from:cfbl-address:cfbl-feedback-id:from; bh=js3H4uRCjQLyIPWBtOMqgiTTKC3EjStT37QGtUZaDG4=; b=LiUGesblx5Nwu+JTiNG38S2ijptcr1boCTMQ4IQKit34TtbCDKUPJTSc0cPmPVvE4A891RfmJ8Cee 2DNVC4PYEtZiC8Qm4KCVE3nJBVsoprGghVejJgfqdJQdWWzQtaC0NQ94iNxa4EEgYkUiCQTwDkKDIc faCHKx7CGwCpVIdA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-type:mime-version:message-id:date:references:in-reply-to:subject:cc: to:from:cfbl-address:cfbl-feedback-id:from; bh=js3H4uRCjQLyIPWBtOMqgiTTKC3EjStT37QGtUZaDG4=; b=XbTTUuFD+CfHPB69Ohgy3jyyW2hK+cewHZebfiitCyHevevcfhYcGW+aWHg2evhR10pNI0cWwqflC 6+WsorOvMHbbQtaENaAJiQOGhTFKp1r1L/FQ08Eeol9WysXuv6g5xW5dQO9Sf+waz4zrWMvGtX3hKn /mDjT44BEcIeOTTR+CH/sC3Zvvbxs71o3Bpf/HQIu/UN27RksWZwh0XrcwOhujPlWsMtlltfi++8PE 6KW7DZRH7NrX5CWSzsp0JhF2NAzDYD0vCg5jEpo83bgOoPrk9eaXJfSOfQE8OHb3Q3c64X6W2bZjIH s18jh07929LwiNfCiRr7mb3nPwKWdiQ== X-Originating-IP: 130.180.31.158 X-MHO-RoutePath: dG9ta2lzdG5lcm51 X-MHO-User: cc6af11a-be7d-11f0-b95c-5f56af36decb X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Mail-Handler: DuoCircle Outbound SMTP CFBL-Feedback-ID: cc6af11a-be7d-11f0-b95c-5f56af36decb:9 CFBL-Address: prvs=040923d279=abuse@outbound.mailhop.org; report=arf Received: from mail.duncanthrax.net (mail.duncanthrax.net [130.180.31.158]) by outbound3.eu.mailhop.org (Halon) with ESMTPSA id cc6af11a-be7d-11f0-b95c-5f56af36decb; Mon, 10 Nov 2025 21:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=stackframe.org; s=dkim1; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=js3H4uRCjQLyIPWBtOMqgiTTKC3EjStT37QGtUZaDG4=; b=h3ufuxt28pvKVdAFT0F5zFm/lW yVFeCFyOA2vFdukZV7I2iuURZ25rdh6n9TwhChaqGR/1zNf2VMOrN6H473vgvVTn9nSn9XKTS7x89 lo4DlOmTXy/bYpWdHwQVFknmD8CKmhHWjXUSM57L6xpXWgm0hRyDobTp7j24yKrGj55GcyGzYp53r gDCwcs6kN2HdJG3VmMfbmkUSPFE3NJfl8tmWrhO7ajxAcrE3ib4Jmwbypxb+nMgvwPYOHHW0K6c3L KH+CSpaulH6A03WHicx3zcLfOv5xfXxC+et+wITWZV/5iuYecsQkULbPjVBJcD4EF8DvGUuiXxdNT fOItA/Sg==; Received: from [134.3.93.166] (helo=debian.stackframe.org) by mail.duncanthrax.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97) (envelope-from ) id 1vIZcB-00000005pfw-2wOK; Mon, 10 Nov 2025 22:39:55 +0100 From: Sven Schnelle To: Simon Marchi Cc: gdb-patches@sourceware.org, Helge Deller , John David Anglin , binutils@sourceware.org Subject: Re: [PATCH v3] gdb/hppa: guess g packet size In-Reply-To: <08dd0dbb-b105-4039-b81e-4569b3a44065@simark.ca> (Simon Marchi's message of "Mon, 10 Nov 2025 16:38:25 -0500") References: <20251110210717.152087-1-svens@stackframe.org> <87zf8th8s7.fsf@stackframe.org> <08dd0dbb-b105-4039-b81e-4569b3a44065@simark.ca> Date: Mon, 10 Nov 2025 22:39:54 +0100 Message-ID: <87v7jhh8id.fsf@stackframe.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 11/10/25 4:34 PM, Sven Schnelle wrote: >> Simon Marchi writes: >> >>>> + warning (_("target returned a target description this gdb doesn't " >>>> + "support for the HP/PA architecture")); >>> >>> Good idea to put out a warning. I would suggesting some minor changes >>> to the message: >>> >>> warning (_("The target returned a target description but this gdb " >>> "doesn't support target descriptions for the HP/PA >>> "architecture")); >>> >>> Just thinking out loud: it would actually be nice to have this warning >>> for all architectures that don't support target descriptions, if there >>> was a way to put it at a single common place. >>> >>> Other than that, the patch looks fine. >>> >>> Approved-By: Simon Marchi >>> >>> Do you have push access or would you like me to push the patch on your >>> behalf (with the modification proposed above)? >> >> I don't have push acess - would appreciate if you could adjust the >> message and push it. > > Done, thanks. I even extended the message to: > > warning (_("The target returned a target description but this GDB " > "doesn't support target descriptions for the HP/PA" > "architecture. Assuming standard 32-bit register" > "layout.")); Thanks! One nit pick - I think there's a superfluous whitespace before 'Assuming standard 32-bit...'