From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ucI7Oj8ahmkZWywAWB0awg (envelope-from ) for ; Fri, 06 Feb 2026 11:43:43 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=gG1LAd0W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E91031E0BA; Fri, 06 Feb 2026 11:43:43 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3F4F51E08D for ; Fri, 06 Feb 2026 11:43:43 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D0AE743C1CB6 for ; Fri, 6 Feb 2026 16:43:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D0AE743C1CB6 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=gG1LAd0W Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id B429A43C1C95 for ; Fri, 6 Feb 2026 16:42:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B429A43C1C95 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B429A43C1C95 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770396172; cv=none; b=LgX8X9GPtvnlKGLtlVtJWskOqZ21qhPP9M/EHgaE9s+gPabX0RUJFk/RjRh4QDDPmR/eT577DLd7LdeTxPubPzGsv3PerC+k9Civ08EXYxwh3wUlxPmH0kAeFOp3nKwBvQjBDMFGm6xqpI2yywIaBtGMksRIj6A0yGH3+mrEYJQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770396172; c=relaxed/simple; bh=U5LhMJH7fDPvP90iUWcoB+rhM8XdZxw5NRPIVpgL5p4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=U8DoZRqrn9eM8wWd3OCZparrLeEs/BGDG6YBbBdJ//ki/BqvokNetZRnzYnbJixNLimvLVjXTQRlC5u2w037ivggYHf3DsMfUhAgtkgBovVb3vyfN1DhSGn3yGr5slVsnp443LpeBYijB3ixct/jky646EFWLEgF1axUfqqru9c= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B429A43C1C95 Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id oIA8vZZnIVCBNoOuxv81a5; Fri, 06 Feb 2026 16:42:51 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id oOuwvCnjHV6WMoOuxvgCC1; Fri, 06 Feb 2026 16:42:51 +0000 X-Authority-Analysis: v=2.4 cv=E//Npbdl c=1 sm=1 tr=0 ts=69861a0b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=HzLeVaNsDn8A:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=6mX_zTVF33pOT9DxNS8A:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=nQKvhZC92H2uKaAjJswZ634sN0ZDdklfzLhv24LgHBk=; b=gG1LAd0WO74g7xmDhn9Olz6rTQ VFo2H1Sc0EcVm0JbGSh/mpkBBskoqarxqIrGt+huSK2R1xm9FJ5Mgm3m4iuQswKCyKRMXIjy3t6W1 eD8XNbXDXVdlSeDIfTc5HOmBW; Received: from 97-118-49-200.hlrn.qwest.net ([97.118.49.200]:33970 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1voOuw-00000000tcS-2nv3; Fri, 06 Feb 2026 09:42:50 -0700 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union In-Reply-To: <20260206025238.3467043-1-simon.marchi@polymtl.ca> (simon marchi's message of "Thu, 5 Feb 2026 21:52:30 -0500") References: <20260206025238.3467043-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 06 Feb 2026 09:42:49 -0700 Message-ID: <87v7g94yd2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.118.49.200 X-Source-L: No X-Exim-ID: 1voOuw-00000000tcS-2nv3 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-118-49-200.hlrn.qwest.net (bapiya) [97.118.49.200]:33970 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDRf2RdDT2aVmEWA9ZZ4DsnprZGqibCWFqTZcuE2AD71gFjxQy4XM8HpIP2s8eDLGkOUyFAi/ciDkHIpdjb5nykp0kpyYBrGYyj6PPQoMNRgB2y/YD/Y XsXu4eTnUib0yZQXyKy05WCrIMOdlF9DGgtF+1tX3cz/oWkBso/qtbZQXzt2zUEs88W5cBvC4Lgjo+phekQPvyIr4vFq285IaHI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> The block field is never used. The block is only used to grab a Simon> reference to the mdict, which is stored in the mdict_iterator. Simon> Remove it and remove the union. Leave the compunit_symtab field, whose Simon> name unfortunately conflicts with the method. Seems reasonable to me. Using an m_ name wouldn't be remiss, we have other cases where we've done this but where the field is still "public". Simon> else Simon> { Simon> - iter->d.block = block; Simon> - I didn't look to see how the initialization is done, but I wonder if this should assign nullptr to the compunit_symtab field. Approved-By: Tom Tromey Tom