From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6di/OAxTtGl73ScAWB0awg (envelope-from ) for ; Fri, 13 Mar 2026 14:10:20 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FolLWJua; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E27C51E089; Fri, 13 Mar 2026 14:10:20 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 68DA41E089 for ; Fri, 13 Mar 2026 14:10:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id D11D94B3589E for ; Fri, 13 Mar 2026 18:10:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D11D94B3589E Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FolLWJua Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 904D24BC7ED4 for ; Fri, 13 Mar 2026 18:09:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 904D24BC7ED4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 904D24BC7ED4 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773425394; cv=none; b=Zz0MabyQK5fBAJvWFD7TqdMG9tYObxy/XOhDq6HNxsIua2+NX3/IPaFjNp4TOahBZLeGkhzARI0VyoAunFhGclAkAg2f3F+cI4XZeGKKRbTTB6iVsBmj0lfMyG/u25vgI+1Dd/LSgBs6NLsSjONH6l4T68hoV1oB7TWwQ2PNJPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773425394; c=relaxed/simple; bh=WM5mcvLDruuZdrk30fwHpp5gbqZZ1Y/xe/Se45A5bYk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=H18magWwDjnxEI8mWksPKZIOrD+9y6JC4lNMXrSqkrSRzFek11JyVpdl+6MrrkfdsusLurLrPLEga4OX21tKGJrBpY7HFzd3O1T3UBhv3SCXrq12rVGbFym8Qmo5FYhAbJkfgWi4libt0Oj0NknQRGKfHYEE4FJBPLBINFUaiGY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 904D24BC7ED4 Received: from eig-obgw-6001b.ext.cloudfilter.net ([10.0.30.143]) by cmsmtp with ESMTPS id 11BWwgT9AKXDJ16xOwrz3S; Fri, 13 Mar 2026 18:09:54 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 16xGwnkaMcu1116xHw3pGr; Fri, 13 Mar 2026 18:09:47 +0000 X-Authority-Analysis: v=2.4 cv=bKYWIO+Z c=1 sm=1 tr=0 ts=69b452f1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=zstS-IiYAAAA:8 a=ZmVPLQqTKzjUe0_l-HEA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4gO2tdVVXCWZ1dxzWrnUsAgwBJDTJDmOUW+95n3L2IQ=; b=FolLWJuaije79dTkmAIHuGhGB3 mKOyFKqROxWRj4TlrmXiJnzht21LIazlriIEDLHU9kv/nZNuKky4h68NLmp9ZCkcPUq+s6JfLj07S DrmQAB0a/L0uL21nxVXNBMT2d; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:33186 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w16xG-00000000DVd-2wyH; Fri, 13 Mar 2026 12:09:46 -0600 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v3 7/7] gdb/python: add accessor helpers for __dict__ in Python extension objects In-Reply-To: <20260309175624.236491-8-matthieu.longo@arm.com> (Matthieu Longo's message of "Mon, 9 Mar 2026 17:56:24 +0000") References: <20260309175624.236491-1-matthieu.longo@arm.com> <20260309175624.236491-8-matthieu.longo@arm.com> X-Attribution: Tom Date: Fri, 13 Mar 2026 12:09:45 -0600 Message-ID: <87v7ezr47q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w16xG-00000000DVd-2wyH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:33186 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfH9q8SaHgWSzdeUR9vvzx0khMizBuzh7vRwEBoEyGy6Omr2yDd0Vt1lHxL+9idFUF9StTgmZLUKPcwi9bQ/vBRKTOD9Xbx/QAxfQnZAkE2sKyla8oIbl FNUZXA7GLgRuUq2gicKbspsWaoGJ2c90UzyARFKMtZASJG06M4qSgmdgCXD5qJOsl5aCBqrbXfmivZZ1ZJp6bIj833o5mpLyz5w= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Matthieu Longo writes: > Python extension objects that support __dict__ must inherit from > gdbpy_dict_wrapper, a wrapper class that stores the PyObject > corresponding to the __dict__ attribute. Because this dictionary > is not managed directly by Python, each extension objects must > provide appropriate accessors so that attributes stored in __dict__ > are looked up correctly. > + #define gdbpy_dict_wrapper_cfg_dict_getter(object_name) \ > + { \ Don't indent the '#define' > + #define gdbpy_dict_wrapper_getsetattro\ > + /*tp_getattro*/ \ Here too. Ok with that fixup. Approved-By: Tom Tromey Tom