From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aRwjMm1Z4mn6Lx8AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 12:01:49 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FlvXGLC5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B620E1E04F; Fri, 17 Apr 2026 12:01:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E55781E04F for ; Fri, 17 Apr 2026 12:01:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 51F184CD201B for ; Fri, 17 Apr 2026 16:01:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 51F184CD201B Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=FlvXGLC5 Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 705A14BA540B for ; Fri, 17 Apr 2026 15:54:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 705A14BA540B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 705A14BA540B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776441248; cv=none; b=TJ45ImQ6UdpRlrrVQIT6dVrg6jjPFFfFYskLpOFYq3zWAmjhlP6MPq4npeFwhXfn2sy14gV7gpUWfrx1/vjYGNvb6Prg9+y/5rH0x2GUxFRG0MrFCgQlQOPTgUOkNjmUnDybTFkd7uzkvBnA285ccrcoktZr3538N6+IEvjbSW0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776441248; c=relaxed/simple; bh=3r7BHFRy5wzu4HajcFmR8uQgCQQX3rjMvtgT0nfMr4M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LH0a7JENAqCy7G6XanQ7mayXMSc6akptQ0MqyWsFuMve+dy77El7vkxrSRcLy4tntEai56f/dWSgH1yf5cWA8qUQ4yFCPcI3OYJsl2JUrtIxDAym7hzulfyctdxZSTfXzBJLugzX6k0YJvf6RmfofWHX04vy+7FxfNew08741yk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 705A14BA540B Received: from eig-obgw-6005b.ext.cloudfilter.net ([10.0.30.162]) by cmsmtp with ESMTPS id Dl8twxVySObRfDlWCw1ewp; Fri, 17 Apr 2026 15:54:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id DlVywr9JBFeDMDlVywZ7Ol; Fri, 17 Apr 2026 15:53:55 +0000 X-Authority-Analysis: v=2.4 cv=aq2yCTZV c=1 sm=1 tr=0 ts=69e2579f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=A5OVakUREuEA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=dv_jzpsDq5hYitetUk8A:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mph9ZJjCNqYg0C6KdF9gvMQRVaFqiEStS+g0ds9ONgk=; b=FlvXGLC5OspgFXKlcPtvFjY00D HsdeiBp9etSLcoy+5rvzHaVkWvyLY9zKFAHg0NGYrPKeL0LPvgVaolz2dwNNnr11vzj0tAyuOYdrT ustIEVilKdG/gIADUR3aGwyOZ; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:49208 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wDlVy-00000003Tvk-1d1z; Fri, 17 Apr 2026 09:53:54 -0600 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v1 3/4] gdb/python: migrate Python initialization to use the new config API (PEP 741) In-Reply-To: <20260409105155.1416274-4-matthieu.longo@arm.com> (Matthieu Longo's message of "Thu, 9 Apr 2026 11:51:54 +0100") References: <20260409105155.1416274-1-matthieu.longo@arm.com> <20260409105155.1416274-4-matthieu.longo@arm.com> X-Attribution: Tom Date: Fri, 17 Apr 2026 09:53:53 -0600 Message-ID: <87v7dpshv2.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wDlVy-00000003Tvk-1d1z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:49208 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfP10ZfJdRx+/styumlcXdCzkL2ptz6n3gk0TytMM5+jfbGrYYWZWWC/xlJUpLDB7UXxpz6yLnGOEmwPyxIZ4Th+n6Tn1OSqC+EBNrClJOUffp1ZBLLpA 9tMqrvZdVKs5CN9nbKMFuVuQwTRGf0GsioJWcJBJhlc7ul81mkXdpGcaaEA7+tyWQ/yochjeqAQlASMv3F4zvrzQX2OlJUI+JMA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Matthieu" == Matthieu Longo writes: Matthieu> + PyInitConfig *m_config; Matthieu> + bool m_err; Matthieu> + bool m_py_initialized; These last two can just say '= false' Matthieu> +}; Matthieu> + Matthieu> +gdb_PyInitializer::gdb_PyInitializer () Matthieu> + : m_config (PyInitConfig_Create ()), Matthieu> + m_err (false), Matthieu> + m_py_initialized (false) ... then they don't have to be initialized here. Matthieu> +{ Matthieu> + if (m_config == nullptr) Matthieu> + { Matthieu> + throw_error (GENERIC_ERROR, Matthieu> + _("Python initialization failed: memory allocation failed")); No need for the braces. Also this can just be error (...), throw_error is normally only for special things. Matthieu> + const char *err_msg; Matthieu> + if (PyInitConfig_GetError (m_config, &err_msg) == 1) Matthieu> + throw_error (GENERIC_ERROR, Matthieu> + _("Python initialization failed: %s"), Matthieu> + err_msg); Matthieu> + Matthieu> + int exit_code; Matthieu> + gdb_assert (PyInitConfig_GetExitCode (m_config, &exit_code) != 0); Can't combine a side effect with an assert here. Matthieu> + throw_error (GENERIC_ERROR, Matthieu> + _("Python initialization failed with exit status: %d"), Matthieu> + exit_code); Also same here about error; and does this code need to clear the Python error or anything like that? Matthieu> + catch (const gdb_exception_error &exc) Matthieu> + { Matthieu> + gdb_printf ("%s\n", exc.what ()); Use exception_print instead, probably with gdb_stderr. thanks, Tom