From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id aUbOI7tCT2oQTC0AWB0awg (envelope-from ) for ; Thu, 09 Jul 2026 02:42:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=l2LSQ8Jv; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8BB251E098; Thu, 09 Jul 2026 02:42:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C8FC11E04F for ; Thu, 09 Jul 2026 02:42:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B94A94BA2E1F for ; Thu, 9 Jul 2026 06:42:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B94A94BA2E1F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=l2LSQ8Jv Received: from mail-yx1-xb12e.google.com (mail-yx1-xb12e.google.com [IPv6:2607:f8b0:4864:20::b12e]) by sourceware.org (Postfix) with ESMTPS id 1D5434BA5434 for ; Thu, 9 Jul 2026 06:41:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D5434BA5434 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1D5434BA5434 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b12e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783579298; cv=none; b=H+YZYquJpW6XGvp5WYbLiqC55l2sciL/Duj7yU0JIalrc6jOPth7WinfuVREydfWYbivHkpIXiBVJhLYOiNOACgH1vW7AeKA37xSPzZyqXWuLk+424xhxNCCjlBnA9BgLfSOGcHIhXTIVuI1/KfhlI1lbLnB7JHjdaQmn9Ug2/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783579298; c=relaxed/simple; bh=Km2WYjkrI45XaTAavM2ztvWCT8VwL/JFzx/SSmFeG/Q=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=uPIDow9RSmUdx1xr2Cd1I7M6PBHOVgG6lqCdgguR9XXOfIebG4k8ksnJ8UnVf/51/8fdHkfmkRmxFAN53ix0k58uGJpfb7QZJ2EN3i6M1T+M/liJaGXYN99MsHBQ4Ne0rgCIgtOF0iBN20Db4SvQnRoaRmkHKD3TG4/gy1rgL0M= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=l2LSQ8Jv DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1D5434BA5434 Received: by mail-yx1-xb12e.google.com with SMTP id 956f58d0204a3-667971437d6so1995269d50.2 for ; Wed, 08 Jul 2026 23:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783579297; x=1784184097; darn=sourceware.org; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=wVuEvrT/OTwqsSkwB5++VdxFEi2tTn3527DZPgkdP58=; b=l2LSQ8JvPriqKfhckqjgN1luf4xrkkVUoCepzn+RBNwXaBWmr/uJd0QdAvtIFI6CK7 xmII901YJ51QfZvwkgITU/JFxkXT3gjGeo7+kmLR+7YFL4MbXfqmzgm24ropXqHHuX99 rZ1DGrmjtv4u+/J73oHj1eJdF4TCJA0h1RqbQN+zZMGFOCV18mmTco8EtENhzeuetdbv n8j0noAndkE+pJScKXTbglTZhMJrWMqXeUoCSk4cOagZSqFdXNQnMWJzgCGYyFKC7d4u D4NW0mTTyKVZztLDMpqTB67zC21bNFAzxjjGnD+PP9ZM5NMBeUAnLfnuYwr5nvQcU+CQ hBOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783579297; x=1784184097; h=content-type:mime-version:message-id:date:user-agent:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=wVuEvrT/OTwqsSkwB5++VdxFEi2tTn3527DZPgkdP58=; b=A5reYMA8yIIWMk5OTZHb4iXSQj8prQnEo2D6T5RsRBEtuP9m6HdAc8IC/mtGdF8O4Z wiYFe8pjKyueFM5zRrcWuorqRZiCl+5dhGXpxmaWYD+DaOIjwEBlXc1t0khR+j0M20GO aWjEJWsPFhHOsdCQ0Rsn78W6NEllP9WYaLK6/tBtt4IcG8qSf8qMRw/9H6aSYs4wGCru OOVe0+btg/MxQmmeDorNUvak6O/vwTS56n1lcm9+9X1nUr+4tIMYtwH7O1N1ggFyY5Cn 0CX7vQj4P8R6cilh9DxLWAErS864QnPKsTga4Sih9suscSVpcnHmek6MLmf7E0WsOXwI hF1g== X-Gm-Message-State: AOJu0YxMUyvFPvJ7/RbgOqskm3/YUlb9b2npHxcUi6KTKU8FCFNad/r6 TwsxXVssEDS+CmRdAEwQP7QSOZfCWqUNOv9har6MCDD9niFtzlc0G39Cq4Q+sV8lOiA= X-Gm-Gg: AfdE7clZkwrDW6a2NgpjvXZ/hO9vHEl48Glk4054fkioy7VdkVts3I9O6PSAQgeqEnR aPZLhtmJtqlgHpfX8ETeSJcdImOHj2QCa5QMw3X0JbrXL83iYCSYY4X6xt62BGWIPcM9gCaBs+t diZ3ilajIIjuoBmi8ToZnRRys/kSh6CwS9dN3rYiUoEkuDx4xVqq0lnF8/ECkdZJFf+rtZXXHEi UqFhcXuE2SKieu7akEMuDZDYFAq7AkAeh/6iT1ngQuNxOL9IRdMta+bkQxY+B3qeWd7nT1A+kSa oBMG0IKvV+nhEvfON4JQ03JVEdHasCqe6AaCEFF0djxN8Aemmy8N6S/6Hc5e/wfwGAP8vJfUsBE BfhojQ445JOV2aLTAdlKMNQVBUaSCHsUQzs4ykRqmTW7t4I96FebjHubpjf7dEgLgiJzvdf9r6l z7Zt2fM7I/3qpw0hAFkG0vmxA= X-Received: by 2002:a05:690e:d44:b0:662:e0f6:ccbb with SMTP id 956f58d0204a3-6679f0a5c74mr3951116d50.35.1783579297494; Wed, 08 Jul 2026 23:41:37 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8083:f04c:42e3:5943:38f6]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6678775de35sm3581844d50.3.2026.07.08.23.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:41:37 -0700 (PDT) From: Thiago Jung Bauermann To: Matthieu Longo Cc: , Luis Machado , Luis Machado , Andrew Burgess , "Yury Khrustalev" , Pedro Alves , "Tom Tromey" Subject: Re: [PATCH v1 08/10] gdb/linux-tdep: migrate parse_smaps_data to file_reader_t In-Reply-To: <20260707154900.94542-9-matthieu.longo@arm.com> (Matthieu Longo's message of "Tue, 7 Jul 2026 16:48:58 +0100") References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-9-matthieu.longo@arm.com> User-Agent: mu4e 1.14.2; emacs 30.2 Date: Thu, 09 Jul 2026 06:41:33 +0000 Message-ID: <87v7aozmua.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Matthieu Longo writes: Suggestion: mention in the commit log that since the previous commit, the old variant of parse_smaps_data is unused. > --- > gdb/linux-tdep.c | 30 ++++++++++++------------------ > 1 file changed, 12 insertions(+), 18 deletions(-) Reviewed-by: Thiago Jung Bauermann > @@ -1628,8 +1627,9 @@ parse_smaps_data (const char *data, > > if (sscanf (line, "%*s%lu", &number) != 1) > { > - warning (_("Error parsing {s,}maps file '%s' number"), > - maps_filename.c_str ()); > + warning (_("Error parsing numeric value associated with " > + "key '%s' in {s,}maps file '%s'"), > + keyword, freader.c_filepath ()); Nice improvement to the error message, thanks. > break; > } > if (number > 0) -- Thiago (he/him)