From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gdwxK+vGfGpNFyEAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 15:18:03 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=jqYw57z7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AB3081E166; Wed, 12 Aug 2026 15:18:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3EC9B1E09B for ; Wed, 12 Aug 2026 15:18:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C9EEA4BB3B85 for ; Wed, 12 Aug 2026 19:18:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9EEA4BB3B85 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=jqYw57z7 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id BE55B4BB3BA3 for ; Wed, 12 Aug 2026 19:17:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE55B4BB3BA3 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE55B4BB3BA3 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786562259; cv=none; b=HjPo65CwhcTZRuXypTMSg8QL5gPyJIkffzmUsZ9HxlVGj4zq/7LOaQeyvjDSdcDo/2rAVXSih9tmG3YTNyFpUa+JtU/ntQ3U717qhX/UvaLEmOAZvPCITuDqeTwUQ1Lx0eRJ54OOSDFCbCPAJhq+AQ+yvhtjOapYbiSXf0OV0/Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786562259; c=relaxed/simple; bh=127xEFaWDiWUOh0BF2CADTnIqaXddzge+4MgzNXC8TA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kZc7o88KRCTzNZcGzKixiAyHh9lQSm86BJr8jQW3DrcjJBJxLlMzeq9rMs4C0w9yW4PPQixXOnCQWo0G+2CmXii2sq01L6P9JY6NNnk40Hud+L1Wp84KRMcGVv8Ej+duIFRKo5f7sE8AKOAvYbM4TEkucUQJ8Gsw4VI6m2RBvMc= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=jqYw57z7 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE55B4BB3BA3 Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-7f39cfb65cbso2653a34.1 for ; Wed, 12 Aug 2026 12:17:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1786562259; x=1787167059; darn=sourceware.org; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=127xEFaWDiWUOh0BF2CADTnIqaXddzge+4MgzNXC8TA=; b=jqYw57z7f7WKYjF7ZRHl2JBfG8CmlDfRKZ+keNmfnsEFFAMWHdzlWffIubel8IfrvB RV/WoT91tqjjebeyUA2ZMJ6x21EC+6J+gNzgBLUVf12zEpdf9oP+ITcplsGBoOA6RDKz 4f7bXlTHMxiw7CURaDT6SJjtQl8fSBGHY58Zq/E4i1Gxm4X1cRTzoBNqMXNiQIbHteqd OTUjDZoTJ/smK3T6ulEb7qsE2N9/7CD2pI9OeKsAES6vQJblXRu27KSFLGhdlolD18Wq Vih3pzxN5glvs7G+tt5zpHgc8GlsWrme7IGvJa6Sp74yMI1tZPJ+sgterXbNZ6rqq9/6 JLVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786562259; x=1787167059; h=content-type:mime-version:user-agent:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=127xEFaWDiWUOh0BF2CADTnIqaXddzge+4MgzNXC8TA=; b=Cwk6getHAaPddRSWHrv5aQExNri3yiNzHdp7RgB38DcX/w745bUhdCgm8xRDk6GWbt rgw3bRUmtjqX89uuW88NU13vrn2EEcGFwuubwNDy/E84HYOs06kE/O9kmNzgy5O0T96r djMNW+ojFfO/A6Yn8clYk/ZF7Ozkg2lsbRkoAovAbg/R3sEK6lcG7uQ8ng8FTSajN7Ld g8gMebVDPy1mWK6o2Vq5JJPgynoLqXgy4uKpe8lOS8GCYIfPOs1mmpR1ciQ1Dz3H/lkA EbJfF0wJinsRO7ci/gECPKlYXSr0nOSKyKRu2m5jfWgSfVd3AgvrvXXyXsShR8dhZm3i ExRg== X-Forwarded-Encrypted: i=1; AHgh+RoVrhZC17vVKZr7ix3iR06EwqCGyR+hHf9km+YW7xlVZJmpcHx9cd7n7w3K9T4/HnUKCSuBITl4pIg3Aw==@sourceware.org X-Gm-Message-State: AOJu0YyQE8KqqYVvb1VM2pdxYL5WktMJS0jyWD8ufBQNCDBwP17nb1zI 0wvKfnA/lx3RQGyPcNey7YGeQyzW4mm9DrAn0JFKeLtkvTtY6dFoD5fncUiu64BwfQ== X-Gm-Gg: AR+sD12U7zNWyKBQ3/FET2+z15jM5q8MLgVGEBPu4K7MVjA+itaYw6FAhl+ZraqSgq9 GBXwF+qNdEGY3Z7am9LSCqi3UCPj2SqNaO7hT3bq7C+zHj4rQuEihyvhiNfaxObO7QMOcpv6MfH +oqS6wSs3Xn3tl++GfbjD+76/q63spGHdhqDM+/3a0PvNcFMucxC3fcHUJwU7X1TTI4ymROjY4R FVEDxcyIqECc4vl6kiyt6KfyYCxX2NEQzSPnE+m3SWxE/3VXxXwtQTlKdSszbD5+8fczJQMPzNU ery3WIghcDz9RpWfgZwSwnNtexQ0KlMZ9gH21s7weSVTZMMrPL1lgFN/CyKXmjVMrfwqbKPuInN OXiu4cb6PW1JdTcCkVawsG3uMUL6LvbAFpR2JJ6kWLwlXCnkOvpcwpW3SuG/TPyq1n0s2QRattS nB9hqPYDWD+Fy1va2Onz2qi1p9VWXvETDnggxbcM8HA2TKJugm/3Zztm7wnczgXRX0TpIN2HUMJ WYiDcFX X-Received: by 2002:a05:6830:2aa2:b0:7e6:f582:955e with SMTP id 46e09a7af769-7f3ca674ba1mr28422a34.10.1786562257982; Wed, 12 Aug 2026 12:17:37 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f3c9ca7adasm110144a34.17.2026.08.12.12.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 12:17:37 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Use F_SETFL after F_SETOWN In-Reply-To: <8d1ae798-aa8c-411e-8dfc-59f7f85dcef2@simark.ca> (Simon Marchi's message of "Wed, 12 Aug 2026 11:34:49 -0400") References: <20260717-f-setfl-v1-0-0d1eec47cf25@adacore.com> <20260717-f-setfl-v1-2-0d1eec47cf25@adacore.com> <8d1ae798-aa8c-411e-8dfc-59f7f85dcef2@simark.ca> X-Attribution: Tom Date: Wed, 12 Aug 2026 13:17:36 -0600 Message-ID: <87v79fw3lb.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> While touching these lines, could you maybe indent the inner #if and Simon> #endif? Sure thing. Tom