From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AevDFOcqg2pUMC0AWB0awg (envelope-from ) for ; Mon, 17 Aug 2026 11:38:15 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fPuUbdFx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 50F901E0A3; Mon, 17 Aug 2026 11:38:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E118A1E033 for ; Mon, 17 Aug 2026 11:38:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8C1A14BA902F for ; Mon, 17 Aug 2026 15:38:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C1A14BA902F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fPuUbdFx Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 29F9D4BA900C for ; Mon, 17 Aug 2026 15:37:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 29F9D4BA900C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 29F9D4BA900C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786981021; cv=none; b=xnfQyvVx1NmXliEKtQeqnD2UE2a5GZcY+1IdsTFg8KtEgGu9rAIKnSO6b9+tt6mJNDU96RIJrqL9u1AkFmcNQ+BXnDQY/9yGyw196sa/kDZ7AhiO3SucXMcO8wnq5VVr/WWmUkdmbFJ/nfrYoXSj5KAGdGda6L1m8JUClhttcMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786981021; c=relaxed/simple; bh=t4tO0IWzjkgaAQvLuISVyaNN7FrSsJYea5MFedWrZdU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=TsA4sicETmmUb1Jx4m4DsHZ6B64qUkDpU5HDOx5b8CKuwj9GK8F5ycnlI7Ak3lDG/BGpN+MHm2u6zbDXa+ikRjwuCL+VijUpLaWzzzBPBjwqL1jRyOUw9mF0Xl/+HFrGT41VB19nUWzB9QdJgiqWA5YrkK9nZwyTfdHi+ODfzSw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=fPuUbdFx DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 29F9D4BA900C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786981020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pdxY0pZhtpslAbO9RxzimpmvErbHC7xU2UQCqKjC2vM=; b=fPuUbdFxF82hcAmImO/5dEURi4Hv8FTUpmiEIi0qZYQVNxQQ2Sg5qy2W1MjtTudR6r37fA ASeev2qzUYi82OaYOTxwj0FMvS6e0u7TfknrZ67mRLWS+S3PbpKna1CdxUjMlDAHGy8TyY x2HS9tOjrqIwMZysnRzZ3UPrsSX5fmc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-294-flMVmi0qOqilAD45qTGyAg-1; Mon, 17 Aug 2026 11:36:59 -0400 X-MC-Unique: flMVmi0qOqilAD45qTGyAg-1 X-Mimecast-MFC-AGG-ID: flMVmi0qOqilAD45qTGyAg_1786981018 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4955843c6cdso34119465e9.1 for ; Mon, 17 Aug 2026 08:36:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786981018; x=1787585818; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=pdxY0pZhtpslAbO9RxzimpmvErbHC7xU2UQCqKjC2vM=; b=gY+4a3zkuATa5i8FKnVEYmhmSTIP70hA7QEVKS8wB2flosA2dmuZwb/8nU892z4EEj SZEwg+3ma+AmQgRZJHs0PZbir/gHj0M34WJr1JRjCj1o5OrwXk9tjzSxuQEHi2iFXxlb 1nGAp1YZhHbSkhc5v9A1L/govZnDBUoYgC6oWtkbm69deuBrFqTJAT4qDZl++8JgkWKt ott2Mh1CSmJhmZZWTCiruDs4Bz1wc6wvM6RfhkOp2AcV5nwSeCYmtMFLMIcn9XSmY4me NHAkcXZVYS9BaKTMThJKiJfr3hxU/le252TyoeMS4+e5N4eG1+q0DngeGsm5OFdG5hDU m5PQ== X-Forwarded-Encrypted: i=1; AHgh+Rqfttde+c8fYvsnMUqldaGdd9r9K5bZkEQcPXBthIudL8bKEqD0zNuVmKB3AxbOFADcvrykv3yoAlD5pQ==@sourceware.org X-Gm-Message-State: AOJu0YyldKNtQnpiYGsOh0MKy/YtwTe3J0Nq/npq3rSB2660aP83Cy2N PevWThYoKmltCXvMLAboMGBOyCBl8yoybIPGKAilzOyIZK/5O/H6GJ/fo+clWk+y+8FM4aPp+4C 3ECZ9bmYU6kR7FLLcaK/UEytFu9akbQXC1Oq5buG+SaxUltyIppjIyxPS0a7x58UlXw+taE4= X-Gm-Gg: AR+sD11pvwYeit1XA9G4BPkiw/dIFFHWF2y/2nnq/NWVryzTFrH5mBbWyAMAoxRK2u3 QVjvxmnMUar4JYdzwUoaUp4CVx3QX+eVGlU8/3MqcD6TwsmwI68ThFzYEyxqzinMAhntpsAbwZ0 ZclXr9cBIjcnHWPTvJtFTpFQlakWlJMmeHxCwtV9d5i5bPDKnPeAVjggWPm67TBm9iEScGa5vpy 5s/re5sRqDULR35/uiOPMehvCJlM7WS7ADfEBzikex/HajqNlLBKNvdibpbaG2/YCEZCaT6IrJt UoWEiM66AilWQ7ri5uW6bPCRrLigBoRtFs3fUh6RFu+lWPNvU7Vuisa1IMrxSHem/H0WTpYUzKx WQcsJz364ffZW89JCBe0= X-Received: by 2002:a05:600c:8714:b0:499:8704:242c with SMTP id 5b1f17b1804b1-499878ca13bmr466095795e9.0.1786981018075; Mon, 17 Aug 2026 08:36:58 -0700 (PDT) X-Received: by 2002:a05:600c:8714:b0:499:8704:242c with SMTP id 5b1f17b1804b1-499878ca13bmr466095025e9.0.1786981017663; Mon, 17 Aug 2026 08:36:57 -0700 (PDT) Received: from localhost (67.72.115.87.dyn.plus.net. [87.115.72.67]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49996100184sm196059965e9.1.2026.08.17.08.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2026 08:36:57 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org, binutils@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 05/13] sim/m32r: fix unused variable warning on non-Linux hosts In-Reply-To: <20260817151646.152571-6-simon.marchi@efficios.com> References: <20260817151646.152571-1-simon.marchi@efficios.com> <20260817151646.152571-6-simon.marchi@efficios.com> Date: Mon, 17 Aug 2026 16:36:56 +0100 Message-ID: <87v7983giv.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: gRxBYCWubHY3cHbEremdl4PAB3irBO4eKB1EkobsWKc_1786981018 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > When building on macOS, I get: > > /Users/smarchi/src/binutils-gdb/sim/m32r/traps.c:191:18: error: unused variable 'cb' [-Werror,-Wunused-variable] > 191 | host_callback *cb = STATE_CALLBACK (sd); > | ^~ > > All the uses of `cb' in m32r_trap are inside the TRAP_LINUX_SYSCALL > case, which is guarded by `#ifdef __linux__'. Move the declaration > inside that case, so that it only exists where it is used. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: I609850daf7fa60d92856988dffe7e314eb1d8a30 > --- > sim/m32r/traps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sim/m32r/traps.c b/sim/m32r/traps.c > index 7b98b2453972..bb82ae80e2aa 100644 > --- a/sim/m32r/traps.c > +++ b/sim/m32r/traps.c > @@ -188,7 +188,6 @@ USI > m32r_trap (SIM_CPU *current_cpu, PCADDR pc, int num) > { > SIM_DESC sd = CPU_STATE (current_cpu); > - host_callback *cb = STATE_CALLBACK (sd); > > if (STATE_ENVIRONMENT (sd) == OPERATING_ENVIRONMENT) > goto case_default; > @@ -217,6 +216,7 @@ m32r_trap (SIM_CPU *current_cpu, PCADDR pc, int num) > #ifdef __linux__ > case TRAP_LINUX_SYSCALL: > { > + host_callback *cb = STATE_CALLBACK (sd); > CB_SYSCALL s; > unsigned int func, arg1, arg2, arg3, arg4, arg5, arg6, arg7; > int result, errcode; > -- > 2.55.0