From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qUyEM2QBsWrHmSsAWB0awg (envelope-from ) for ; Mon, 21 Sep 2026 06:05:24 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Dkv2Cydq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AC8151E01F; Mon, 21 Sep 2026 06:05:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7B8091E01F for ; Mon, 21 Sep 2026 06:05:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 008CB4BA2E26 for ; Mon, 21 Sep 2026 10:05:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 008CB4BA2E26 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Dkv2Cydq Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id EAB524BA2E08 for ; Mon, 21 Sep 2026 10:04:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAB524BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EAB524BA2E08 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789985094; cv=none; b=WymZYJeutsRiIqtLF89a1LfOkKjlVCXzUnqwGYwYZzs8kw9MhnJUwfq17ENt/PORcVLUhiiD+SRu4OBv/0egkvrvQpwJEXWcUOLZVPsSE3NrrjvK4uyNpZPfTaG2Uo7F1oNdz8UJHACeJatCGYBe845TUzjZTyuR3EBlHS1Yurg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1789985094; c=relaxed/simple; bh=44vg7ajyBAioJcVCrYLg7tQ2poJE9ixk3qKZsAbEgt8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=wLTjA7vNi37QONMi3fDKucEmaWSiZGKCyDv1JRygPt7wA1OuVuTM6DGLcgoZXvyxqNCs97VQgpuowQxTNMJ17sezqd3P5OdKyttQIx/MKPXlPprwLqsHqc2vpNg1lqlN8/Qfz/PGCuS8tW985aOOMxqNAKlzO6CM9YWl8VqV2HQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Dkv2Cydq DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EAB524BA2E08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789985093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ozQD+am9jBTz0/7B7ZM8AhLdYy+UnpAY0YNzhvBk1ew=; b=Dkv2CydqzfpahF3XraAZsIssen2Mh2C2+FOGOw7ZOp1kDrHyNOP9Mef4xQMv8cc5d1kkgt RTD8HrgEtyRqtnHy3mXR/vy+B/Eh0+lL8pI0ld01cwyFheRxtYO/GOvq+Zw3afrYx3NrYg bDnuYQ4o+ILe16l9mdhMWSa1L27AeLA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-_F2ikoJoNG2nLhqIRtYYKA-1; Mon, 21 Sep 2026 06:04:52 -0400 X-MC-Unique: _F2ikoJoNG2nLhqIRtYYKA-1 X-Mimecast-MFC-AGG-ID: _F2ikoJoNG2nLhqIRtYYKA_1789985091 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-49e745d5dabso31871575e9.0 for ; Mon, 21 Sep 2026 03:04:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789985091; x=1790589891; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ozQD+am9jBTz0/7B7ZM8AhLdYy+UnpAY0YNzhvBk1ew=; b=ltnZrr3oISr3s5t1AMjhVmj8ELfQs8MgtINx7BLBdTxdgNyCXlpKa3QpXRXQqlebO0 K7nbUgcbtknfuLdYFoy6gxB2bPvI1TdXW8iyvMvc5C/ZrXOC3Oh8xA8/2K+vBmH+vEMX 5RUtUqyEX8dwCk/nXRgFA7ECkwq/n7mwvAL5tomY+AWpP+qHV1NiAgQGaak5fZ7kzstC XOdZfZm9KKwz4+RQnMRfHWxiKrW9KKurxqxl1Q9JTvThRSAEr36APWURxMU2ur4BiW3Y rgt0Ajrtc87r1Bx7KugIe7lnG8+KEdBbPNDRqfbgSIrGoJciQd/TWG6DLxVOhtp4b7dr lqvA== X-Forwarded-Encrypted: i=1; AKwUvBwSbmKfxKArAdXSJRovJMHHl6lcn52KnmzUhaYjOjnRSCF8WGkd38ayoLbY72McLuiDmZPiNhRnBU5udw==@sourceware.org X-Gm-Message-State: AFuF++kU8YkOyHDCeF98cgntm4MYfL/lUe08DHPMiXDpUjPd85RwwHih Swbq2JvsJgj8fQq/oMLLNhtzjK+NEyLaYzf6Nzho5WjATJu4Z3ObrQ2JwJ5C0Ptf5htnewqWS92 oOMuE/BRDaGJ6j/veblcEY3w50fKXYNorRov9apVn7mOtoPlbovci0rpWZ7MBXeI= X-Gm-Gg: AYBFou09UAvTCrda+8HDbxQ7Mau71R3qAZ6b2wSnY0D71g3Yb8J/KAsFGALnEKP3kxy filxzsBgN8klK+QMP0LxuPadcm1Pgr/Dy//NvbhT2lm87SgHt/8x/fERxZEzw1MLEqqrAnhbU24 C9CxwAkA8jDWFnpuJg8MuvGFTVWEfXK0rkrhMpNBYgtYlQaZaXViMOKEKPAVlDLJFVO7ddpojoM oDTtBUVZx8YCDzc0W17TQARUjum3nOLB6aFlJPDfxeMRPY752oMuw6F5TK+dv0TBIi0Ggee942C XXMeoIsViwnC6FLGymPqVqC0R4HoipIX1aE8OnId+QBFjnBvYorKCQcfy2CkpSBpZn8wSqU= X-Received: by 2002:a05:600c:4f86:b0:49f:bd3c:bc25 with SMTP id 5b1f17b1804b1-49fc574e7d3mr138586775e9.32.1789985090602; Mon, 21 Sep 2026 03:04:50 -0700 (PDT) X-Received: by 2002:a05:600c:4f86:b0:49f:bd3c:bc25 with SMTP id 5b1f17b1804b1-49fc574e7d3mr138586385e9.32.1789985090162; Mon, 21 Sep 2026 03:04:50 -0700 (PDT) Received: from localhost ([83.216.138.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fcd07cca6sm217037325e9.11.2026.09.21.03.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 03:04:49 -0700 (PDT) From: Andrew Burgess To: "Joos, Christina" , "gdb-patches@sourceware.org" Cc: "Rohr, Stephan" Subject: RE: [PATCH v2 1/1] gdb: Enable OS generated corefiles on systems with Intel AMX support. In-Reply-To: References: <20260911163001.3365986-1-christina.joos@intel.com> <87y0cxa21o.fsf@redhat.com> Date: Mon, 21 Sep 2026 11:04:48 +0100 Message-ID: <87v77yapj3.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: feulXXrj5N8eEkpOo8_wZ9M3_gzEFTPpuD80I4fmLNY_1789985091 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org "Joos, Christina" writes: >> -----Original Message----- >> From: Andrew Burgess >> Sent: Samstag, 19. September 2026 13:55 >> To: Joos, Christina ; gdb-patches@sourceware.org >> Cc: Rohr, Stephan >> Subject: Re: [PATCH v2 1/1] gdb: Enable OS generated corefiles on systems with >> Intel AMX support. >> >> Christina Joos writes: >> >> > This patch addresses the issue described in PR gdb/34561. On systems >> > with Intel AMX support the xsave size is 11008. This xsave size is >> > not handled by gdb/i387-tdep.c:i387_guess_xsave_layout and is causing >> > problems for corefiles generated by the linux kernel. The problem is >> > visible regardless of the AMX enablement state in the dumping process, >> > so all corefiles on newer systems with AMX are broken. > > Hi Andrew, > > Thanks a lot for pushing this patch. > >> FYI: https://sourceware.org/bugzilla/show_bug.cgi?id=34646 >> Could you take a look if you have a chance please. > > As described in the discussion for v1 of this patch [1], the issue described in the bug > 34646, just became visible due to the improved test coverage for core files, which > are also part of this patch. > They are unrelated to the GDB code changes of this patch, so the issue existed before, > too. I added a comment in the bug, so this is hopefully clearer now. > > [1] https://sourceware.org/pipermail/gdb-patches/2026-September/230279.html Thanks for the explanation. This makes sense. Would you be OK if I pushed the patch below to master and gdb-18-branch? This converts the FAIL to XFAIL and points back at PR gdb/34646. I did consider creating a brand new bug, but that seemed a little pointless. Thanks, Andrew ~~~ commit 95bb312d0f65229d914adffe143c6e561cb285bf Author: Andrew Burgess Date: Mon Sep 21 10:12:44 2026 +0100 gdb/testsuite: add xfail to gdb.arch/i386-pkru.exp test script Add an xfail to the new gdb.arch/i386-pkru.exp test script, which is currently failing due to a preexisting issue. The test script was added to master in commit: commit eec39a2f9250c622d86219cc182c4feaa6b07c50 Date: Fri Sep 11 18:30:01 2026 +0200 gdb: Enable OS generated core files on systems with Intel AMX support And back-ported to gdb-18-branch in commit: commit 1d77334943a940a0384f6177cc8ceb9dd3852c17 Date: Fri Sep 11 18:30:01 2026 +0200 gdb: Enable OS generated core files on systems with Intel AMX support The test triggers the OS to generate a core file. GDB then loads the core file and inspects the PKRU register. Currently, this register does not contain the expected value. This is an existing issue that existed before the above commit(s). As it is not good to introduce new FAILs, I'm changing the test to report XFAIL if we get anything other than the expected PKRU value. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34646 diff --git a/gdb/testsuite/gdb.arch/i386-pkru.exp b/gdb/testsuite/gdb.arch/i386-pkru.exp index 07a589cba82..926cc7dbfff 100644 --- a/gdb/testsuite/gdb.arch/i386-pkru.exp +++ b/gdb/testsuite/gdb.arch/i386-pkru.exp @@ -113,14 +113,24 @@ gdb_test_multiple "print /x rd_value" "variable after reading pkru" { # Restart gdb, load the core file generated by gcore or the OS # and check reading the pkru register from the core file. -proc test_corefile {core_filename} { +proc test_corefile { core_filename { allow_xfail false } } { clean_restart $::testfile gdb_test "core $core_filename" "Core was generated by .*" \ "load core file" - gdb_test "info register pkru" ".*pkru.*$::val1.*" \ - "read pkru register" + gdb_test_multiple "info register pkru" "read pkru register" { + -re -wrap ".*pkru.*$::val1.*" { + pass $gdb_test_name + } + -re -wrap ".*pkru.*" { + if { $allow_xfail } { + xfail "$gdb_test_name (PR gdb/34646)" + } else { + fail $gdb_test_name + } + } + } } with_test_prefix "OS generated core file" { @@ -133,7 +143,7 @@ with_test_prefix "OS generated core file" { if { $corefile eq "" } { unsupported "unable to generate core file" } else { - test_corefile $corefile + test_corefile $corefile true } } }