From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yYTSNdR3vmoDKiQAWB0awg (envelope-from ) for ; Thu, 01 Oct 2026 11:10:12 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=akH1+b21; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D5FB41E01F; Thu, 01 Oct 2026 11:10:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6D1211E01F for ; Thu, 01 Oct 2026 11:10:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 565EA4BB3BF2 for ; Thu, 1 Oct 2026 15:10:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 565EA4BB3BF2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=akH1+b21 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 8E8CA4BA2E10 for ; Thu, 1 Oct 2026 15:09:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E8CA4BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E8CA4BA2E10 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790867382; cv=none; b=JhrXByyfvfj4CkqHct3Gu+yktg654ywtfHMzGYjIFrmVr99oSZwZ1yodQFBqv3DBU9N9YPm3NnRPWIb+mgitKXwWokE3IZlByRXRE3crvVg+sv4uWdS+zf/7ElTSRFSlQ2Hx+tAt8Xuwsooc8f0bZB+NqwJAqiNkW82gBfA3swo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790867382; c=relaxed/simple; bh=efETEDP1e6ZpjPlHpMJDP2n9HPGSr8Qu0xRvoVK2MQQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qv9mWcdsItuBG7QWFJrKCSeO5m/uEwKEavK0EDa2gTqDD0uKxQOaIIwEJr2wlxRntObZ6x8FLO3UdB/H9e+2U9MnrBgmcyCzhQkYtphIwU+2cj8o2+otTvPzISm42TQ8OH8VVWVZjXauTVSQUdrv++2pSKANppA61DxM6r4QNZA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=akH1+b21 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8E8CA4BA2E10 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790867382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+oc0JHzz8FZfuA/yI0VcE0d3LOSudj/VpmUfEzBKZEc=; b=akH1+b21D6DAMUNoqShfaHB5q4mPZSy/AukCPiVxQQGMSicKk5nrUMLr9ugRr6bPRh0Qt1 IMYuvMNSgHKQ1uhFCmtCrzi5XTj7Rhg/yJZg0MjfV7KOt+DmAj47BbrsgZ4rrIL7xuPiOR fqvPKHrP7WFMffRVRuW27Lp2ybv6xVY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-444-Od2-rh2xOiqNhkmTGU5c-Q-1; Thu, 01 Oct 2026 11:09:40 -0400 X-MC-Unique: Od2-rh2xOiqNhkmTGU5c-Q-1 X-Mimecast-MFC-AGG-ID: Od2-rh2xOiqNhkmTGU5c-Q_1790867379 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a01b112fa2so19622785e9.1 for ; Thu, 01 Oct 2026 08:09:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790867379; x=1791472179; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=+oc0JHzz8FZfuA/yI0VcE0d3LOSudj/VpmUfEzBKZEc=; b=y0N5/7NuPW2C8YvsLGEInRvRo6YpqNWChox7WU4w9QsVp6wOnREIZgJybfv6rpbffd 6VH7RUsXODxTbWpQl6HYBHF4cWegRXZoqlk4ECBFcCwB+z5hpD1GtweKvEtH+5aH1cH+ hn1pEjVIp26eFSOsvOIce3Ai+dQ5//4PQpevnf5fl8LvLN80zL6W8fMQV11fFjQ11eyN dWSJ4Z1bAo3+x3St+Sy4QwvLE5s2sjDE3ERyrnegtAts2hPgDuVsaZjK7whtI1G+fcj0 BWl3hg05Gr+BRp8QfxMlykbnWhjoI5cHrMNHPFjytJGyymGgLfNNKUY1/4eu/TJawQv0 xlyw== X-Forwarded-Encrypted: i=1; AKwUvByCKWip1Nd5lURfvRHqxXzfBJTmOHv0fjEL2AEYZaPBDxgH+z1zbCkvawHRljEQDEI4gcd1ddPMr2NShA==@sourceware.org X-Gm-Message-State: AFuF++kAjYrsaLQ+CKwGKeUEHN5SEumw5vIaUwxKYlhkXShaKf9kmcJn bXJCnoCoFh8unfl8yY0l1zd7bUI8XocnVrq5i9VuTE3sus3mQZ2+WFYBNsJZgf8CZb9h+ASbv9H k7qMVFch2eN/z5kY7fTnsvO7TN+krQjLWMvGidWj0mbQb4Dwfx9oLCKPnm73MH3w= X-Gm-Gg: AYBFou18G1tW1eiNt8RmGTxF8RJEFySECXpoQSs3DvPP0TPFMddIdy1IejRAZjxQlb7 gs/OZx0vmDsYLb3Ii2eT815I9gnVLQ9FKfYC7AgzLs7Ku6eieLceGFPD2w++4ZDqmeq93JKmih/ eWClXPp53GN+LN1USnx/iOAFqkyxevFMZu2TrydwSWpee0I9peKLm1zM8UZiB+PLWNxKqvLxVoO +Ed5UWVIVkqybGyOBeZ+YMJyBUXEA68g8S4cZHtko9AWXBaF7Rj/EZOFIqhexT8a0OccwqOtiwJ ZIEXeG2iAv34W2TBsn2KOnBP/q4tbt6FQbrHpcXLb8/C7m6sPj5sYm0nEhUZLejXP925 X-Received: by 2002:a05:600c:a10a:b0:4a0:1c16:d6f6 with SMTP id 5b1f17b1804b1-4a01c16d8bfmr68081245e9.24.1790867378831; Thu, 01 Oct 2026 08:09:38 -0700 (PDT) X-Received: by 2002:a05:600c:a10a:b0:4a0:1c16:d6f6 with SMTP id 5b1f17b1804b1-4a01c16d8bfmr68080695e9.24.1790867378368; Thu, 01 Oct 2026 08:09:38 -0700 (PDT) Received: from localhost ([213.31.44.29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a01ff0cd17sm69425685e9.9.2026.10.01.08.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Oct 2026 08:09:37 -0700 (PDT) From: Andrew Burgess To: simon.marchi@polymtl.ca, gdb-patches@sourceware.org Cc: Simon Marchi , "Rohr, Stephan" Subject: Re: [PATCH v2 07/11] gdb: make global_symbol_searcher::is_suitable_msymbol non-static In-Reply-To: <20261001020952.698419-8-simon.marchi@polymtl.ca> References: <20260929194119.155169-1-simon.marchi@efficios.com> <20261001020952.698419-8-simon.marchi@polymtl.ca> Date: Thu, 01 Oct 2026 16:09:37 +0100 Message-ID: <87v77lxxse.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: taVt3vstproMc3qNpS1ukGuSlrOspqLfAhJC3s6f-Us_1790867379 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org simon.marchi@polymtl.ca writes: > From: Simon Marchi > > is_suitable_msymbol is a static method taking the search kind as a > parameter, but all callers pass m_kind. Make it a const non-static > method that uses m_kind directly. LGTM Approved-By: Andrew Burgess Thanks, Andrew