From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17518 invoked by alias); 11 Jun 2012 20:57:19 -0000 Received: (qmail 17508 invoked by uid 22791); 11 Jun 2012 20:57:19 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jun 2012 20:57:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5BKv2MX025102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Jun 2012 16:57:02 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5BKv0sf030825 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 11 Jun 2012 16:57:01 -0400 From: Tom Tromey To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: FYI: fix latent bug in dw2_find_symbol_file References: <87d3558zcz.fsf@fleche.redhat.com> Date: Mon, 11 Jun 2012 20:57:00 -0000 In-Reply-To: (Doug Evans's message of "Mon, 11 Jun 2012 13:49:54 -0700") Message-ID: <87txyh7ejn.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00315.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> You need to call init_cutu_and_read_dies in both debug-types and Doug> non-debug-types cases. When DWO files are in use DW_AT_name lives Doug> in the DWO file. OTOH TUs typically don't have DW_AT_name (you Doug> need to look at DW_AT_decl_file). OTOOH this function is only Doug> called by find_main_filename. What gcc branch should I use to test this? And do I need gold? Doug> I'm tempted to rename the routine {,*_}find_function_file (or some Doug> such) and have dw2_find_symbol_file ignore TUs. Fine by me, but I don't plan to do it. Tom