From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31279 invoked by alias); 23 Jul 2012 15:03:57 -0000 Received: (qmail 31270 invoked by uid 22791); 23 Jul 2012 15:03:56 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jul 2012 15:03:38 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6NF3btn003732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 23 Jul 2012 11:03:37 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q6NF3ah6008596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 23 Jul 2012 11:03:36 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 01/10] change gdb to refcount bfd everywhere References: <87vchk3lxs.fsf@fleche.redhat.com> <20120719141750.GB23801@host2.jankratochvil.net> <877gtzxyck.fsf@fleche.redhat.com> <20120722190009.GA25479@host2.jankratochvil.net> <877gtusfb7.fsf@fleche.redhat.com> Date: Mon, 23 Jul 2012 15:03:00 -0000 In-Reply-To: <877gtusfb7.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 23 Jul 2012 08:49:32 -0600") Message-ID: <87txwyr03c.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00450.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> I wonder if I should rename it to gdb_bfd_open_maybe_remote, for Tom> consistency. What do you think? I'm inclined to do it. Jan> Definitely. Tom> I'll do this shortly. Here's that patch. I'm checking it in. Tom 2012-07-23 Tom Tromey * symfile.c (separate_debug_file_exists): Update. (gdb_bfd_open_maybe_remote): Rename from bfd_open_maybe_remote. (reread_symbols): Update. * elfread.c (build_id_verify): Update. * symfile.h (gdb_bfd_open_maybe_remote): Rename from bfd_open_maybe_remote. Index: elfread.c =================================================================== RCS file: /cvs/src/src/gdb/elfread.c,v retrieving revision 1.136 diff -u -r1.136 elfread.c --- elfread.c 23 Jul 2012 14:58:44 -0000 1.136 +++ elfread.c 23 Jul 2012 15:03:15 -0000 @@ -1109,7 +1109,7 @@ int retval = 0; /* We expect to be silent on the non-existing files. */ - abfd = bfd_open_maybe_remote (filename); + abfd = gdb_bfd_open_maybe_remote (filename); if (abfd == NULL) return 0; Index: symfile.c =================================================================== RCS file: /cvs/src/src/gdb/symfile.c,v retrieving revision 1.341 diff -u -r1.341 symfile.c --- symfile.c 23 Jul 2012 14:58:44 -0000 1.341 +++ symfile.c 23 Jul 2012 15:03:15 -0000 @@ -1353,7 +1353,7 @@ if (filename_cmp (name, parent_objfile->name) == 0) return 0; - abfd = bfd_open_maybe_remote (name); + abfd = gdb_bfd_open_maybe_remote (name); if (!abfd) return 0; @@ -1697,7 +1697,7 @@ returns NULL with the BFD error set. */ bfd * -bfd_open_maybe_remote (const char *name) +gdb_bfd_open_maybe_remote (const char *name) { bfd *result; @@ -2516,7 +2516,7 @@ obfd_filename = bfd_get_filename (objfile->obfd); /* Open the new BFD before freeing the old one, so that the filename remains live. */ - objfile->obfd = bfd_open_maybe_remote (obfd_filename); + objfile->obfd = gdb_bfd_open_maybe_remote (obfd_filename); gdb_bfd_unref (obfd); } Index: symfile.h =================================================================== RCS file: /cvs/src/src/gdb/symfile.h,v retrieving revision 1.112 diff -u -r1.112 symfile.h --- symfile.h 20 Jul 2012 17:38:04 -0000 1.112 +++ symfile.h 23 Jul 2012 15:03:15 -0000 @@ -550,7 +550,7 @@ extern bfd *symfile_bfd_open (char *); -extern bfd *bfd_open_maybe_remote (const char *); +extern bfd *gdb_bfd_open_maybe_remote (const char *); extern int get_section_index (struct objfile *, char *);