From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20503 invoked by alias); 26 Sep 2012 15:07:26 -0000 Received: (qmail 20488 invoked by uid 22791); 26 Sep 2012 15:07:25 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 26 Sep 2012 15:07:12 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q8QF7AxE028660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Sep 2012 11:07:11 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q8QF79r4003288 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 26 Sep 2012 11:07:10 -0400 From: Tom Tromey To: Joel Brobecker Cc: Siddhesh Poyarekar , gdb-patches@sourceware.org Subject: Re: [commit][obv] Use TYPE_LENGTH directly where possible References: <20120926132621.5f45acb7@spoyarek> <20120926094227.GA4335@adacore.com> <20120926152740.0900e9b7@spoyarek> <20120926105205.GB4335@adacore.com> Date: Wed, 26 Sep 2012 15:07:00 -0000 In-Reply-To: <20120926105205.GB4335@adacore.com> (Joel Brobecker's message of "Wed, 26 Sep 2012 12:52:06 +0200") Message-ID: <87txukzuua.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00590.txt.bz2 Joel> But I can definitely see someone like myself missing that subtlety, Joel> and commit an obvious change that reduces the duplication by re-using Joel> the variable in the gdb_assert call. To the unattentive me, that's Joel> an obvious improvement. I think that's an issue. Yeah, that's easy to picture happening. It seems to me that a comment would be adequate. Tom