From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31762 invoked by alias); 3 Dec 2012 19:11:17 -0000 Received: (qmail 31752 invoked by uid 22791); 3 Dec 2012 19:11:16 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Dec 2012 19:11:06 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB3JB3JH023638 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 3 Dec 2012 14:11:03 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB3JB2qh021081 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 3 Dec 2012 14:11:02 -0500 From: Tom Tromey To: Hui Zhu Cc: Hui Zhu , gdb-patches@sourceware.org Subject: Re: [PATCH] Add CTF support to GDB [2/4] Fix a bug of function dwarf_expr_frame_base References: <50AC322D.2030209@mentor.com> <87k3t45ihq.fsf@fleche.redhat.com> Date: Mon, 03 Dec 2012 19:11:00 -0000 In-Reply-To: (Hui Zhu's message of "Sun, 2 Dec 2012 00:33:33 +0800") Message-ID: <87txs3vtmh.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00037.txt.bz2 >>>>> "Hui" == Hui Zhu writes: Hui> What about I change it to "frame address is not available." because in Hui> get_frame_block: Hui> if (!get_frame_address_in_block_if_available (frame, &pc)) Hui> return NULL; Seems reasonable to me. This is ok. Tom