From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26406 invoked by alias); 6 Dec 2012 21:48:22 -0000 Received: (qmail 26396 invoked by uid 22791); 6 Dec 2012 21:48:21 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Dec 2012 21:48:11 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB6Lm9TG009996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 Dec 2012 16:48:09 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB6Lm73j027827 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 6 Dec 2012 16:48:08 -0500 From: Tom Tromey To: Hui Zhu Cc: gdb-patches ml , Hui Zhu Subject: Re: [PATCH] Add fseek to ui-file References: Date: Thu, 06 Dec 2012 21:48:00 -0000 In-Reply-To: (Hui Zhu's message of "Thu, 6 Dec 2012 17:45:34 +0800") Message-ID: <87txryx36w.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00120.txt.bz2 >>>>> "Hui" == Hui Zhu writes: Hui> And stdio_file_fseek has a place different from the other stdio_file Hui> functions. It check the return of fseek. If it got error, it will Hui> throw error. Hui> If you think it is OK, I will post patch for other stdio_file functions. Hui> If not, it will update this patch. Thanks. Hui> void Hui> +set_ui_file_fseek (struct ui_file *file, ui_file_fseek_ftype *fseek) Hui> +{ Hui> + file->to_fseek = fseek; I found the argument name 'fseek' confusing here, since this mimics a global function of the same name. Could you rename the argument? Hui> +static void stdio_file_fseek (struct ui_file * file, long offset, int whence) Hui> +{ Newline after 'void'. I wonder whether the null fseek ought to unconditionally throw an exception. It seems to me that it can't really be successful. I think this should go in conditionally based on the other patches -- no need to put it in if it turns out you can't use ui_file after all for some reason. Tom