From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3569 invoked by alias); 7 Feb 2013 21:32:09 -0000 Received: (qmail 3544 invoked by uid 22791); 7 Feb 2013 21:32:08 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 07 Feb 2013 21:31:59 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r17LVw0o022434 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 7 Feb 2013 16:31:58 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r17LVuAP011087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 7 Feb 2013 16:31:57 -0500 From: Tom Tromey To: Phil Muldoon Cc: "gdb-patches\@sourceware.org" Subject: Re: [patch][python] 2 of 5 - Frame filter MI code changes. References: <50B8C333.4070008@redhat.com> <87ip8gtoex.fsf@fleche.redhat.com> <50C1F56E.5060506@redhat.com> <87sj7dd3i7.fsf@fleche.redhat.com> <5110F64C.2040907@redhat.com> Date: Thu, 07 Feb 2013 21:32:00 -0000 In-Reply-To: <5110F64C.2040907@redhat.com> (Phil Muldoon's message of "Tue, 05 Feb 2013 12:08:44 +0000") Message-ID: <87txpnu7xv.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-02/txt/msg00201.txt.bz2 >> Right now, though. -stack-list-frames doesn't take any options. >> I think it would be better if commands like this were converted to use >> mi_getopt instead of doing the parsing by hand. >> So I suggest having all the functions use a short option name. >> >> I think the changes like in -stack-list-locals are strange, too, in that >> they make options order-dependent. This will be surprising to users. Phil> I spent the last couple of weeks trying to fix this, and I have Phil> reached a dead end with your review requirements. Ok. Phil> This is all somewhat tangential to the frame filters patch. While I Phil> do not mind fixing issues as I go, this is becoming an issue far more Phil> contentious than the patch content. Phil> What do you think we should do? For commands like -stack-list-frames, where the additions are new, use mi_getopt. For existing commands with bogus argument handling, just do whatever you can that makes sense. Tom