From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <hui_zhu@mentor.com>
Cc: Hui Zhu <teawater@gmail.com>, Yao Qi <yao@codesourcery.com>,
gdb-patches ml <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] Fix agent code generate bug of ref
Date: Tue, 12 Mar 2013 15:16:00 -0000 [thread overview]
Message-ID: <87txogir7j.fsf@fleche.redhat.com> (raw)
In-Reply-To: <513F4028.5090000@mentor.com> (Hui Zhu's message of "Tue, 12 Mar 2013 22:48:08 +0800")
>>>>> "Hui" == Hui Zhu <hui_zhu@mentor.com> writes:
Hui> According to the discussion with Tom in IRC.
Hui> I add a check before call access_memory.
Hui> + if (size != 1 && size != 2 && size != 4 && size != 8)
Hui> + error (_("Refn doesn't support size %d"),
Hui> + size * TARGET_CHAR_BIT);
The old error message mentioned the actual opcode name.
I think "Refn" is less clear, since it isn't the name of anything
in DWARF.
Tom
next prev parent reply other threads:[~2013-03-12 15:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 5:01 Hui Zhu
2013-03-11 13:39 ` Yao Qi
2013-03-11 14:38 ` Tom Tromey
2013-03-11 14:56 ` Tom Tromey
2013-03-12 2:53 ` Hui Zhu
2013-03-12 14:17 ` Tom Tromey
2013-03-12 14:48 ` Hui Zhu
2013-03-12 15:16 ` Tom Tromey [this message]
2013-03-12 15:25 ` Hui Zhu
2013-03-12 15:27 ` Tom Tromey
2013-03-12 15:47 ` Hui Zhu
2013-03-12 16:18 ` Tom Tromey
2013-03-12 2:22 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txogir7j.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hui_zhu@mentor.com \
--cc=teawater@gmail.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox