From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32215 invoked by alias); 12 Apr 2013 15:45:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32195 invoked by uid 89); 12 Apr 2013 15:45:49 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 12 Apr 2013 15:45:48 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3CFjl5U012047 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 12 Apr 2013 11:45:47 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r3CFjkso018720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 12 Apr 2013 11:45:47 -0400 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/26] Make GDB -Wpointer-sign clean. References: <20130411225847.16791.29283.stgit@brno.lan> Date: Fri, 12 Apr 2013 21:44:00 -0000 In-Reply-To: <20130411225847.16791.29283.stgit@brno.lan> (Pedro Alves's message of "Thu, 11 Apr 2013 23:58:48 +0100") Message-ID: <87txnbhhw5.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00395.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> This makes GDB -Wpointer-sign clean on x86_64 GNU/Linux, Pedro> --enable-targets=all. Once this is in, and perhaps a couple hosts Pedro> more are clean too (mingw and i386 GNU/Linux at least; haven't tried Pedro> those), I'll propose enabling the switch by default. Thanks. I think the sooner it is enabled, the better. Enabling reduces the chances for bit-rot, and fixing up any build problems looks very easy. Pedro> I'm hoping this sort of split makes review easy and allows quick Pedro> turnaround as consequence. I skimmed through all the patches and read ones more deeply where I know the code well. It all looks good to me. thanks, Tom