From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5256 invoked by alias); 24 May 2013 15:50:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5246 invoked by uid 89); 24 May 2013 15:50:21 -0000 X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS,TW_BJ,TW_RG autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 24 May 2013 15:50:16 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4OFoEMb024954 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 24 May 2013 11:50:14 -0400 Received: from barimba (ovpn-113-72.phx2.redhat.com [10.3.113.72]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4OFoAs1023614 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 24 May 2013 11:50:13 -0400 From: Tom Tromey To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFA 1/2, doc RFA] maint check-symtabs, maint expand-symtabs References: Date: Fri, 24 May 2013 15:50:00 -0000 In-Reply-To: (Doug Evans's message of "Mon, 13 May 2013 13:20:59 -0700") Message-ID: <87txls8jil.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00932.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> +static void Doug> +maintenance_expand_symtabs (char *args, int from_tty) Doug> +{ Doug> + struct program_space *pspace; Doug> + struct objfile *objfile; Doug> + struct cleanup *cleanups; Doug> + char **argv; Doug> + char *regexp = NULL; Doug> + Doug> + /* We use buildargv here so that we handle spaces in the regexp Doug> + in a way that allows adding more arguments later. */ Doug> + argv = gdb_buildargv (args); Doug> + cleanups = make_cleanup_freeargv (argv); The cleanup checker noticed that this function doesn't call do_cleanups. Tom * symmisc.c (maintenance_expand_symtabs): Call do_cleanups. diff --git a/gdb/symmisc.c b/gdb/symmisc.c index eb8bbbf..a1ae7bd 100644 --- a/gdb/symmisc.c +++ b/gdb/symmisc.c @@ -898,6 +898,8 @@ maintenance_expand_symtabs (char *args, int from_tty) maintenance_expand_name_matcher, ALL_DOMAIN, regexp); } } + + do_cleanups (cleanups); }