From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5234 invoked by alias); 22 Jul 2013 15:59:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5221 invoked by uid 89); 22 Jul 2013 15:59:34 -0000 X-Spam-SWARE-Status: No, score=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 22 Jul 2013 15:59:03 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6MFwqXG024382 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 22 Jul 2013 11:58:53 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6MFwoFd001219 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 22 Jul 2013 11:58:51 -0400 From: Tom Tromey To: Doug Evans Cc: Joel Brobecker , gdb-patches Subject: Re: [RFA] buildsym.c cleanup References: <87ehd95tl6.fsf@fleche.redhat.com> <20130520090312.GM4017@adacore.com> Date: Mon, 22 Jul 2013 15:59:00 -0000 In-Reply-To: (Doug Evans's message of "Fri, 19 Jul 2013 16:18:41 -0700") Message-ID: <87txjm7fid.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-07/txt/msg00502.txt.bz2 >>>>> "Doug" == Doug Evans writes: Doug> On Mon, May 20, 2013 at 2:03 AM, Joel Brobecker wrote: >>> I have no idea about the COFF change. It isn't clear to me whether >>> coffread and stabsread expect to share the same globals or not. >> >> I do not have a real idea either, but looking at the code, I do not >> think so. The indices used to index the types seem completely >> unrelated... Doug> Hi. So what's the verdict here? Doug> Should we wait until we can find someone to test this on coff, or Doug> check the patch in now. Joel said he thinks the globals aren't shared. If you agree then I think it is fine to go ahead and put it in. Tom