From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 951 invoked by alias); 3 Sep 2013 09:38:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 927 invoked by uid 89); 3 Sep 2013 09:38:31 -0000 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Sep 2013 09:38:31 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,KHOP_PGP_SIGNED,KHOP_THREADED,RDNS_NONE,SPF_HELO_FAIL autolearn=no version=3.3.2 X-HELO: relay1.mentorg.com Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1VGn46-00048A-3y from Thomas_Schwinge@mentor.com ; Tue, 03 Sep 2013 02:38:26 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 3 Sep 2013 02:38:26 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Tue, 3 Sep 2013 10:38:24 +0100 From: Thomas Schwinge To: gdb-patches CC: Luis Machado , , Yue Lu Subject: Re: [PATCH 1/2] Port gdbserver to GNU/Hurd In-Reply-To: References: User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.4.1 (i486-pc-linux-gnu) Date: Tue, 03 Sep 2013 09:38:00 -0000 Message-ID: <87txi2i6t6.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2013-09/txt/msg00065.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2278 Hi! For context, Yue Lu is a student participating in this year's Google Summer of Code program, to port gdbserver to GNU Hurd, and is both a GDB as well as a GNU Hurd newbie. (So, be gentle.) ;-) On Tue, 3 Sep 2013 16:00:32 +0800, Yue Lu wrote: > This is my patch to port gdbserver to GNU/Hurd. Most of code are > copied from [gdb]/gdb/gnu-nat.c. ... and elsewhere. Our strategy was to first get this into a basic functional state: > Now the gdbserver on GNU/Hurd can set breakpoint and check memory or > register(but without float-register support). So, this initial port just posted is a great milestone! Especially so given your previous lack of experience with both GDB and the Hurd -- both of which are not always easy to grasp. There are lots of things to be polished (Yue, don't worry -- this entirely was to be expected), such as GDB coding standard, and changes that are unrelated to your port, which all has to be cleared out before I can commit this initial port to GDB upstream. There is missing functionality, but we decided this can be enhanced piece by piece once the initial port is accepted. There is the issue of code sharing between GDB proper and gdbserver, a strategy for which has been briefly discussed in . Likewise for code sharing between the new Hurd gdbserver port and the existing x86 Linux kernel port. Again I suggest this to be done *after* the initial port is accepted: this will turn into a nice (and easily reviewable) series of cleanup patches =C3=A0 la: remove from GDB proper gdb/gnu-nat.c:[function] and from gdbserver gdb/gdbserver/gnu-low.c:[function], and add gdb/common/gnu-low.c:[function], and so on. Likewise for build infrastructure that can be shared. Does this strategy generally make sense to you GDB maintainers? For the curious, in I describe the MIG usage in GDB. (This message also states that ptrace is a system call which it is not; it's a glibc library function using RPC calls to implement its functionality.) Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 489 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQEcBAEBAgAGBQJSJa4GAAoJEGe3hdm9kOiiDKwIAJ/U8ebf9uBNJ6xZhRMcmpG9 1uYhKUNQeIHGLNv4/54GEYCgWvb6okXWdjB84yg2PqUOw+T3LppEGva+clwJpbyn osswLWWM8wATDSKMRut11OHGk+Ma6iHiSeyKRfkqdR3nivpuXmHMrWQDUuBsMD7m ghTMkx2zk3ueY11j30nGQVi3zjsP+NVSMHpoHIPwmDtkhm341G4HiJ+Ip+F6pSls i1lFysj7Or9wGlZ1Rh2YbpQFFfTkAKPQdufyrdrhi4qnDDb4j8d/cgUjHP3XDPUx sUpT5yjnOTWK1tzpMVQSOeqz8Wojj6vDcJK/LanJGsfhI/8M7CaoulPMW0ZQ4io= =HcG1 -----END PGP SIGNATURE----- --=-=-=--