From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31973 invoked by alias); 10 Oct 2013 19:14:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31959 invoked by uid 89); 10 Oct 2013 19:14:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 10 Oct 2013 19:14:12 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9AJE9wq031590 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Oct 2013 15:14:09 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9AJE8K0018128 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 10 Oct 2013 15:14:09 -0400 From: Tom Tromey To: Sanimir Agovic Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com Subject: Re: [PATCH 2/2] test: ensure certain types exposed to python are not instancable References: <1377873604-15519-1-git-send-email-sanimir.agovic@intel.com> <1377873604-15519-3-git-send-email-sanimir.agovic@intel.com> Date: Thu, 10 Oct 2013 19:14:00 -0000 In-Reply-To: <1377873604-15519-3-git-send-email-sanimir.agovic@intel.com> (Sanimir Agovic's message of "Fri, 30 Aug 2013 16:40:04 +0200") Message-ID: <87txgp5473.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00360.txt.bz2 >>>>> "Sanimir" == Sanimir Agovic writes: Sanimir> The proc gdb_py_test_exception executes a piece of python code and Sanimir> expects an exception of type EXCEPTION to be raised by the code with Sanimir> an optional MESSAGE for fine grained filtering. FWIW I generally put the test cases in the same patch as the modification; same with the docs. That's because they are a conceptual unit. It looks good, however -- Sanimir> + gdb_py_test_multiple "$stmt throws $exception" \ Sanimir> + "python" "" \ Sanimir> + "try:" "" \ Sanimir> + " $stmt" "" \ Sanimir> + "except $exception as e:" "" \ ... there's one version of Python we support that doesn't have this syntax. I forget which one, I know Phil remembers though. Tom