Re: [RFC] Debug Methods in GDB Python

Siva Chandra
2013-05-10T19:55:03Z

On Fri, May 10, 2013 at 12:33 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
>
> Siva> Attached is a new version of the patch which I have now regression
> Siva> tested. Except for tests and docs, I think it is complete wrt the
> Siva> feature set I have in mind. Hence, the caveats from the previous mail
> Siva> still apply.
>
> I'm sorry about the delay here.

Thanks a lot for taking a look. I have had to be away from this work
myself and I will continue to be away for at least a week more. Hence,
I will respond to your comments in detail late May/early June.

For my own reference, I am summarizing your comments as follows:

1. The ext_fn_object should use the GDB style "virtual method" approach.
2. Python related exceptions and error checking are missing.
3. More functions could be static and function comments are missing.
4. Copy-paste errors.
5. One specific comment about thread safety and GIL.

It would also be good to get feedback on the Python side API that I
put together.

Thanks,
Siva Chandra