Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: Substitute '\' with '\\' in extended-prompt
Date: Fri, 17 Oct 2014 04:13:00 -0000	[thread overview]
Message-ID: <87tx33l4l6.fsf@codesourcery.com> (raw)


Hi Phil,
Why do we do the substitute in extended-prompt in your extended-prompt
patch <https://sourceware.org/ml/gdb-patches/2011-08/msg00236.html> as
below?

> +    def before_prompt_hook(self, current):
> +        if self.value is not '':
> +            newprompt = gdb.prompt.substitute_prompt(self.value)
> +            return newprompt.replace('\\', '\\\\')
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +        else:
> +            return None

I don't see any explanations on this in comments or email.

Such substitute makes the output of "set extended-prompt \w" different
from the output of "pwd" nor "os.getcwdu()"

(gdb) python print os.getcwdu()^M
\\build2-lucid-cs\yqi\yqi\arm-none-eabi

(gdb) pwd^M
Working directory \\build2-lucid-cs\yqi\yqi\arm-none-eabi

(gdb) set extended-prompt \w
\\\\build2-lucid-cs\\yqi\\yqi\\arm-none-eabi

My patch <https://sourceware.org/ml/gdb-patches/2014-10/msg00423.html>
doesn't work due to this difference.  I'd like to know whether the
substitute is necessary or not.

-- 
Yao (齐尧)


             reply	other threads:[~2014-10-17  4:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-17  4:13 Yao Qi [this message]
2014-10-17  8:28 ` Phil Muldoon
2014-10-17 11:23   ` Yao Qi
2014-10-22 13:01     ` [PATCH] Don't replace '\' with '\\' in before_prompt_hook Yao Qi
2014-10-29 14:23       ` Yao Qi
2014-10-29 14:34         ` Phil Muldoon
2014-10-29 14:39           ` Phil Muldoon
2014-10-29 23:37             ` Yao Qi
2014-10-30  1:48               ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tx33l4l6.fsf@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox