From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64867 invoked by alias); 27 Jan 2016 18:04:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64821 invoked by uid 89); 27 Jan 2016 18:04:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:888 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Jan 2016 18:04:11 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 7662EC0AC939; Wed, 27 Jan 2016 18:04:10 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0RI492K025394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 27 Jan 2016 13:04:10 -0500 From: Sergio Durigan Junior To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Introduce skip_to_char and use it References: <1453845250-30360-1-git-send-email-simon.marchi@ericsson.com> <878u3b24f8.fsf@redhat.com> <56A8A855.8050208@redhat.com> X-URL: http://blog.sergiodj.net Date: Wed, 27 Jan 2016 18:04:00 -0000 In-Reply-To: <56A8A855.8050208@redhat.com> (Pedro Alves's message of "Wed, 27 Jan 2016 11:21:57 +0000") Message-ID: <87twlyyk4m.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00674.txt.bz2 On Wednesday, January 27 2016, Pedro Alves wrote: > On 01/27/2016 01:32 AM, Sergio Durigan Junior wrote: > >> The problem with skip_to_char IMO is that it leads the reader to believe >> that this function performs the same job as strchr (in fact, my first >> reaction when I read this introduction was to think "why not use >> strchr?"). The main difference, however, is that this function actually >> skips everything if the char was not found. >> >> I believe a name like "skip_to_char_or_nul" may be more appropriate. >> What do you think? > > That sounds just like strchrnul, though. It's not available everywhere, > but, gnulib has a strchrnul module that fixes that. Even better. Thank you, Pedro. -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/