From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34528 invoked by alias); 20 Jul 2016 19:49:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34502 invoked by uid 89); 20 Jul 2016 19:49:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=noisy, H*F:U*tom X-HELO: gproxy6-pub.mail.unifiedlayer.com Received: from gproxy6-pub.mail.unifiedlayer.com (HELO gproxy6-pub.mail.unifiedlayer.com) (67.222.39.168) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 20 Jul 2016 19:49:12 +0000 Received: (qmail 2314 invoked by uid 0); 20 Jul 2016 19:49:09 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy6.mail.unifiedlayer.com with SMTP; 20 Jul 2016 19:49:09 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id M7p51t00Q2f2jeq017p8SQ; Wed, 20 Jul 2016 13:49:09 -0600 X-Authority-Analysis: v=2.1 cv=TIHWFTVa c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=PnD2wP_eR3oA:10 a=C6ZbYQPAFpEA:10 a=cAmyUtKerLwA:10 a=KI1GsZqiWAsgfu5ljxEA:9 Received: from [75.171.160.169] (port=59738 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1bPxUP-0006EO-47; Wed, 20 Jul 2016 13:49:05 -0600 From: Tom Tromey To: "Maciej W. Rozycki" Cc: Tom Tromey , Yao Qi , "gdb-patches\@sourceware.org" Subject: Re: [RFA 5/6] Remove unused variables References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-6-git-send-email-tom@tromey.com> <87wpl9t4l2.fsf@tromey.com> <87furdnubd.fsf@tromey.com> Date: Wed, 20 Jul 2016 19:49:00 -0000 In-Reply-To: (Maciej W. Rozycki's message of "Wed, 20 Jul 2016 19:36:32 +0100") Message-ID: <87twfkks44.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 75.171.160.169 authed with tom+tromey.com} X-Exim-ID: 1bPxUP-0006EO-47 X-Source-Sender: (pokyo) [75.171.160.169]:59738 X-Source-Auth: tom+tromey.com X-Email-Count: 0 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-07/txt/msg00230.txt.bz2 Maciej> Of course one could argue that keeping broken code (though in a manner Maciej> harmless to irrelevant cases) has little value, but at least it serves as Maciej> a reminder to do something about it sometime. I think on the whole it's preferable to file a bug for such cases; or to comment out the offending code and put in an explanation. The warnings catch real bugs; but they are not as useful if they are noisy. Tom