From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125539 invoked by alias); 6 Jul 2017 15:34:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125516 invoked by uid 89); 6 Jul 2017 15:34:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 06 Jul 2017 15:34:40 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E58C27F40D; Thu, 6 Jul 2017 15:34:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E58C27F40D Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E58C27F40D Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B54575DD6A; Thu, 6 Jul 2017 15:34:38 +0000 (UTC) From: Sergio Durigan Junior To: Anton Kolesov Cc: Yao Qi , "gdb-patches\@sourceware.org" , Francois Bedard Subject: Re: [PATCH] Import setenv and unsetenv from gnulib References: <87shid8rt3.fsf@redhat.com> <20170703162737.8386-1-Anton.Kolesov@synopsys.com> <39A54937CC95F24AA2F794E2D2B66B135876DD39@DE02WEMBXB.internal.synopsys.com> <8737ac6j91.fsf@redhat.com> <39A54937CC95F24AA2F794E2D2B66B135876E5CC@DE02WEMBXB.internal.synopsys.com> Date: Thu, 06 Jul 2017 15:34:00 -0000 In-Reply-To: <39A54937CC95F24AA2F794E2D2B66B135876E5CC@DE02WEMBXB.internal.synopsys.com> (Anton Kolesov's message of "Wed, 5 Jul 2017 09:50:47 +0000") Message-ID: <87tw2p4m0h.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-07/txt/msg00039.txt.bz2 On Wednesday, July 05 2017, Anton Kolesov wrote: >> >> >> >> Did you run regression test on x86-linux? If there is no regression, >> >> patches is good to me. >> > >> > If I run "make check-gdb", I don't see any obvious new errors from this >> patch. >> > Unfortunately results are a little bit volatile - some tests >> > sporadically fail even if I run them with same GDB build and sources, >> > even without this patch - I've run testsuite five times and got five similar, >> but different results. >> >> Yeah, our testsuite has racy fails which are well known. What are the tests >> that fail sporadically? > > - gdb.base/checkpoint-ns.exp: break > - gdb.base/checkpoint.exp: break2 with many checkpoints > - gdb.btrace/exception.exp: indented > - Several consequtive tests in gdb.btrace/rn-dl-bind.exp These don't ring any bells for me, but since you're testing on MingW, it may very well be that they're racy tests on this platform as well. My take is that if you can reproduce the exact failures without your patch, then you can discard them as racy. > - gdb.threads/process-dies-while-handling-bp.exp: non_stop=off (KFAIL became > PASS with my patch). This one is a known racy test. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/