From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6977 invoked by alias); 14 Aug 2017 14:31:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5772 invoked by uid 89); 14 Aug 2017 14:31:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:205 X-HELO: gproxy9-pub.mail.unifiedlayer.com Received: from gproxy9-pub.mail.unifiedlayer.com (HELO gproxy9-pub.mail.unifiedlayer.com) (69.89.20.122) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 14:30:53 +0000 Received: from CMOut01 (unknown [10.0.90.82]) by gproxy9.mail.unifiedlayer.com (Postfix) with ESMTP id 843621E08E3 for ; Mon, 14 Aug 2017 08:30:43 -0600 (MDT) Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id x2Wg1v00U2f2jeq012WjmD; Mon, 14 Aug 2017 08:30:43 -0600 X-Authority-Analysis: v=2.2 cv=FrR1xyjq c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=KeKAF7QvOSUA:10 a=20KFwNOVAAAA:8 a=1xVG0sQEXkcXCUeXrb8A:9 a=_RM7nvDVKvkA:10 Received: from 75-166-24-97.hlrn.qwest.net ([75.166.24.97]:52370 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1dhGO7-001LjK-Uw; Mon, 14 Aug 2017 08:30:40 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Fix memory leak in add_symbol_file_command References: <20170811211846.8455-1-tom@tromey.com> <41e0fb1b-2178-4376-4cec-21fe5110e567@redhat.com> Date: Mon, 14 Aug 2017 14:31:00 -0000 In-Reply-To: <41e0fb1b-2178-4376-4cec-21fe5110e567@redhat.com> (Pedro Alves's message of "Mon, 14 Aug 2017 14:51:36 +0100") Message-ID: <87tw1ausqb.fsf@pokyo> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1dhGO7-001LjK-Uw X-Source-Sender: 75-166-24-97.hlrn.qwest.net (pokyo) [75.166.24.97]:52370 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-Local-Domain: yes X-SW-Source: 2017-08/txt/msg00298.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Looks fine to me. A couple nits. Thanks. I fixed these, and I'm checking it in. Tom