Re: [RFA 01/67] Add add_cmd function overloads

Pedro Alves
2017-09-26T12:11:35Z

On 09/23/2017 05:14 AM, Tom Tromey wrote:
>>>>>> "Markus" == Metzger, Markus T <markus.t.metzger@intel.com> writes:
>
>>> static void
>>> +do_const_cfunc (struct cmd_list_element *c, char *args, int from_tty)
>>> +{
>>> + c->function.const_cfunc (args, from_tty); /* Ok. */
>>> +}
>
> Markus> Ok.?
>
> This is copy-and-paste from the other function like this.
> I think this is some way to suppress ARI warnings.

I thought so too, though grepping for "Ok" in the ARI finds
no hits. We have some markers in the tree for ARI, but they
start with "ARI: ". I'd zap the "Ok." comments see what happens.
You can run the ARI locally and compare with/without "Ok."
comments, with something like:

gdb/contrib/ari/gdb_ari.sh -Wall gdb/cli/cli-decode.c

> I don't know if ARI is still used...?

It was still sending notifications to the list as recently as
this month.

Thanks,
Pedro Alves